Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish docs for #2073 #2075

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Finish docs for #2073 #2075

merged 1 commit into from
Oct 4, 2022

Conversation

mcognetta
Copy link
Contributor

PR #2073 was merged before I had finished the docs for the change. This PR finishes the docs for relaxing the RNNCell internal matrix types.

PR Checklist

  • Documentation, if applicable

ToucheSir
ToucheSir approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@ToucheSir ToucheSir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. Feel free to mark something as draft, leave a comment or some other signal if we approve something you're still working on (we've been a bit lax with the checklist lately, I should check that too).

@ToucheSir ToucheSir merged commit 66dddb9 into FluxML:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToucheSir ToucheSir ToucheSir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcognetta @ToucheSir