Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organise "built-in layers" section #2112

Merged
merged 6 commits into from
Nov 30, 2022
Merged

Re-organise "built-in layers" section #2112

merged 6 commits into from
Nov 30, 2022

Conversation

mcabbott
Copy link
Member

@mcabbott mcabbott commented Nov 16, 2022

While moving things around in #2069, I didn't like the "other general purpose" heading in layers.md... so this tried to put them into some less-random arrangement?

Edit: less finished than I thought it was... hence draft for now. Still written as if #1932 were merged. Now all mention of @layer removed.

Also adds a warning about #2122 pending something better.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

Once the build has completed, you can preview any updated documentation at this URL: https://fluxml.ai/Flux.jl/previews/PR2112/ in ~20 minutes

Thanks robot. Humans, see especially https://fluxml.ai/Flux.jl/previews/PR2112/models/layers/ , and compare to: http://fluxml.ai/Flux.jl/dev/models/layers/

@codecov-commenter

This comment was marked as off-topic.

@mcabbott mcabbott marked this pull request as ready for review November 29, 2022 16:45
@mcabbott mcabbott requested a review from Saransh-cpp November 29, 2022 16:46
@mcabbott
Copy link
Member Author

This should be ready, and does not seem likely to be controversial.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mcabbott! Looks good to me!

Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
@mcabbott mcabbott merged commit a8dfcfc into master Nov 30, 2022
@mcabbott mcabbott deleted the doc_layers branch November 30, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants