Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Functors to 0.4, (keep existing compat) #2128

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Functors package from 0.3 to 0.3, 0.4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov-commenter
Copy link

Codecov Report

Base: 86.86% // Head: 86.86% // No change to project coverage 👍

Coverage data is based on head (5c4792f) compared to base (b015b7a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2128   +/-   ##
=======================================
  Coverage   86.86%   86.86%           
=======================================
  Files          19       19           
  Lines        1469     1469           
=======================================
  Hits         1276     1276           
  Misses        193      193           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mcabbott
Copy link
Member

Should run tests after FluxML/Optimisers.jl#121

@mcabbott mcabbott closed this Nov 29, 2022
@mcabbott mcabbott reopened this Nov 29, 2022
@mcabbott mcabbott merged commit bf3cf8b into master Nov 29, 2022
@mcabbott mcabbott deleted the compathelper/new_version/2022-11-29-00-19-37-025-02129879705 branch November 29, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants