Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-deprecate track_stats for InstanceNorm #2149

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

ToucheSir
Copy link
Member

This is mea culpa on my part. Both the original Instance Normalization paper and the PyTorch implementation do allow for tracked stats. The GroupNorm part of #2006 still stands though.

PR Checklist

  • [N/A] Tests are added
  • [N/A] Entry in NEWS.md
  • [N/A] Documentation, if applicable

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Base: 86.88% // Head: 86.79% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (0f46582) compared to base (ee78ce3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2149      +/-   ##
==========================================
- Coverage   86.88%   86.79%   -0.09%     
==========================================
  Files          19       19              
  Lines        1479     1477       -2     
==========================================
- Hits         1285     1282       -3     
- Misses        194      195       +1     
Impacted Files Coverage Δ
src/layers/normalise.jl 88.95% <ø> (-0.14%) ⬇️
src/outputsize.jl 92.70% <0.00%> (-1.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ToucheSir ToucheSir merged commit aba285c into master Jan 5, 2023
@ToucheSir ToucheSir deleted the bc/undep-instancenorm-tracking branch January 5, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants