-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AMDGPU extension #2189
Add AMDGPU extension #2189
Conversation
Updated to the latest NNlib which includes AMDGPU extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks real good, just a few touch-up comments from me. What are your thoughts on CI? Should we wait until the AMDGPU runners are stable before adding a Buildkite pipeline?
I think we can wait until we know the CI is working and then add it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's do this. Thanks @pxl-th !
This PR adds initial support for AMDGPU via extension mechanism.
PR Checklist
FLUX_TEST_AMDGPU
env variable to specify whether to run AMDGPU tests or not.E.g.
Flux.gpu_backend!("AMD")
orgpu_backend="AMD"
inLocalPreferences.toml
allows specifying which backend to use.Therefore I plan to specify adaptor for convolution for
Flux.amd
which will flip weights during conversion once.Not sure if this is optimal way, so if anyone has suggestions do let me know :)