Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove comment on not importing losses in Flux's namespace #2201

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

CarloLucibello
Copy link
Member

No description provided.

@ToucheSir
Copy link
Member

Do we have dep warnings for the losses which will no longer be available? If not I don't think this needs to be part of a major release.

@mcabbott
Copy link
Member

mcabbott commented Mar 4, 2023

What's gained by doing this?

It will certainly break lots of code, e.g. this.

Flux is otherwise quite permissive,e.g. you are not required to notice that Flux.onehotbatch, Flux.flatten and Flux.destructure all come from outside packages. Is it a good idea to require you to know of the existence of this internal sub-module?

@CarloLucibello
Copy link
Member Author

let's keep it then, I just removed the comment

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.25 ⚠️

Comparison is base (484796c) 82.63% compared to head (4f1c8f1) 82.38%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2201      +/-   ##
==========================================
- Coverage   82.63%   82.38%   -0.25%     
==========================================
  Files          23       23              
  Lines        1578     1590      +12     
==========================================
+ Hits         1304     1310       +6     
- Misses        274      280       +6     
Impacted Files Coverage Δ
src/Flux.jl 0.00% <ø> (ø)
src/functor.jl 72.34% <0.00%> (-2.36%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CarloLucibello CarloLucibello merged commit 79b9815 into master Mar 7, 2023
@CarloLucibello CarloLucibello changed the title don't import losses in Flux's namespace remove comment on not importing losses in Flux's namespace Mar 7, 2023
@CarloLucibello
Copy link
Member Author

argh, I should have edited the title before merging 😭

@CarloLucibello CarloLucibello deleted the cl/losses branch March 22, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants