Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiny change to docstring of gpu function #2206

Merged
merged 1 commit into from
Mar 9, 2023
Merged

tiny change to docstring of gpu function #2206

merged 1 commit into from
Mar 9, 2023

Conversation

GSmithApps
Copy link
Contributor

@GSmithApps GSmithApps commented Mar 9, 2023

Changed the docstring signature of the gpu function from gpu(x) to gpu(m) to conform with cpu and to fit the accompanying sentence in the docstring.

This is my first open source PR ever... forgive me for it being so tiny... gotta start somewhere. Cheers to Flux being cool

PR Checklist

  • Tests are added
  • Entry in NEWS.md
  • Documentation, if applicable

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.81 ⚠️

Comparison is base (484796c) 82.63% compared to head (16d0ff5) 79.83%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2206      +/-   ##
==========================================
- Coverage   82.63%   79.83%   -2.81%     
==========================================
  Files          23       23              
  Lines        1578     1577       -1     
==========================================
- Hits         1304     1259      -45     
- Misses        274      318      +44     
Impacted Files Coverage Δ
src/functor.jl 37.34% <ø> (-37.35%) ⬇️
src/cuda/cudnn.jl 0.00% <0.00%> (-100.00%) ⬇️
src/layers/normalise.jl 93.79% <0.00%> (-1.38%) ⬇️
src/layers/conv.jl 88.95% <0.00%> (-0.07%) ⬇️
src/Flux.jl 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for your (first) PR!

@CarloLucibello CarloLucibello merged commit a22a3bd into FluxML:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants