Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f16,f32,.. don't convert int arrays + handle complex #2228

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Conversation

CarloLucibello
Copy link
Member

Close #2225 + support Complex types

PR Checklist

  • Tests are added
  • Entry in NEWS.md
  • Documentation, if applicable

Copy link
Member

@darsnack darsnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be more clear about what the code does.

src/functor.jl Outdated Show resolved Hide resolved
src/functor.jl Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
@CarloLucibello
Copy link
Member Author

should be ready

@CarloLucibello CarloLucibello merged commit 6a68a7c into master Apr 17, 2023
rgobbel pushed a commit to rgobbel/Flux.jl that referenced this pull request Apr 25, 2023
* f16,f32,.. don't convert int arrays + handle complex

* add news

* address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should f16,f32, ... convert integer or boolean arrays?
2 participants