Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type restrictions for recurrent cells #2234

Merged
merged 1 commit into from
Apr 22, 2023

Conversation

darsnack
Copy link
Member

The type restrictions on the recurrent cell input only existed to match the input and weight types. Now, we have _match_eltype, so we don't need such strong restrictions. This simplifies the type signature so that weird types like Nil can also pass through (and _match_eltype already support handling these).

A nice benefit is that we don't need to have a special outputsize rule for recurrent cells anymore.

PR Checklist

  • Tests are added (already exist)
  • Entry in NEWS.md
  • Documentation, if applicable

Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buildkite failure is #2214 (comment) and known, nightly failure is the usual Zygote breaking every new Julia release.

@darsnack
Copy link
Member Author

I merging since the Metalhead failure is known and downstream. What's with AtomicGraphNets? Why does it take so long to run the tests?

@darsnack darsnack merged commit bd392e4 into FluxML:master Apr 22, 2023
@darsnack darsnack deleted the rnn-eltypes branch April 22, 2023 02:37
@ToucheSir
Copy link
Member

I'm not sure. It's been on and off stable over the years, so if CI on master there isn't passing (as is the case now) I wouldn't count it as a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants