Remove type restrictions for recurrent cells #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Buildkite failure is #2214 (comment) and known, nightly failure is the usual Zygote breaking every new Julia release.
|
I merging since the Metalhead failure is known and downstream. What's with AtomicGraphNets? Why does it take so long to run the tests? |
|
I'm not sure. It's been on and off stable over the years, so if CI on master there isn't passing (as is the case now) I wouldn't count it as a blocker. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type restrictions on the recurrent cell input only existed to match the input and weight types. Now, we have
_match_eltype, so we don't need such strong restrictions. This simplifies the type signature so that weird types likeNilcan also pass through (and_match_eltypealready support handling these).A nice benefit is that we don't need to have a special
outputsizerule for recurrent cells anymore.PR Checklist
Tests are added(already exist)Entry in NEWS.mdDocumentation, if applicable