Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove greek-letter keyword from normalise #2252

Merged
merged 3 commits into from
May 3, 2023
Merged

Conversation

mcabbott
Copy link
Member

@mcabbott mcabbott commented May 2, 2023

This case missed in #2139

@mcabbott
Copy link
Member Author

mcabbott commented May 2, 2023

Apparently this is our test of this function (besides the docstring):

@test Flux.normalise(x) == Flux.normalise(x; dims=3)

@ToucheSir
Copy link
Member

Yup...FluxML/NNlib.jl#452 has an actual test suite if you're looking for inspiration.

@mcabbott mcabbott merged commit 7088682 into master May 3, 2023
@mcabbott mcabbott deleted the mcabbott-patch-3 branch May 3, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants