Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small upgrades to training docs #2331

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Small upgrades to training docs #2331

merged 4 commits into from
Mar 5, 2024

Conversation

mcabbott
Copy link
Member

@mcabbott mcabbott commented Sep 9, 2023

Aims to fix #2325 by mentioning that withgradient accepts a tuple.

And to fix #2303 by moving discussion of old-style optimiser structs later.

Also has training doc updates about L1, which should ideally have been in #2330 instead. This should be merged afterwards. Now changed to match #2377 instead.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

Once the build has completed, you can preview any updated documentation at this URL: https://fluxml.ai/Flux.jl/previews/PR2331/ in ~20 minutes

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.30%. Comparing base (95737ff) to head (9d32b74).
Report is 55 commits behind head on master.

❗ Current head 9d32b74 differs from pull request most recent head 6c9cb17. Consider uploading reports for the commit 6c9cb17 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2331   +/-   ##
=======================================
  Coverage   76.30%   76.30%           
=======================================
  Files          31       31           
  Lines        1819     1819           
=======================================
  Hits         1388     1388           
  Misses        431      431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcabbott mcabbott marked this pull request as ready for review March 2, 2024 01:04
@mcabbott mcabbott merged commit 2ff9304 into master Mar 5, 2024
8 of 10 checks passed
@mcabbott mcabbott deleted the doc_withgrad branch March 6, 2024 05:20
isentropic pushed a commit to isentropic/Flux.jl that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants