Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore type stability of conv_transpose_dims #2365

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Restore type stability of conv_transpose_dims #2365

merged 1 commit into from
Dec 31, 2023

Conversation

ToucheSir
Copy link
Member

Inference quality for type indexing and broadcasting seems to have regressed on 1.10. This also gives us an opportunity to clean up the calculations used.

PR Checklist

  • Tests are added
  • Entry in NEWS.md
  • Documentation, if applicable

@ToucheSir
Copy link
Member Author

GPU failure looks unrelated, will try to tackle separately.

mcabbott
mcabbott approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@mcabbott mcabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not checked the calculation, but I trust that you have, and otherwise looks fine.

@ToucheSir
Copy link
Member Author

I actually got it wrong on the first attempt, but the test suite caught that for me. Thank goodness for that :)

@ToucheSir ToucheSir merged commit 1af3f4d into master Dec 31, 2023
6 of 9 checks passed
@ToucheSir ToucheSir deleted the bc/convtrans-dims-typestable branch December 31, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcabbott mcabbott mcabbott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ToucheSir @mcabbott