start testing Enzyme #2392
Merged
start testing Enzyme #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarloLucibello
commented
Mar 8, 2024
|
if tests pass as they should this can be merged. This PR gives us already some good cpu coverage. For CUDA instead, I get some pretty fundamental problems at the moment EnzymeAD/Enzyme.jl#1347. GPU tests will be added in future PRs |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2392 +/- ##
==========================================
+ Coverage 43.04% 45.73% +2.68%
==========================================
Files 32 32
Lines 1856 1863 +7
==========================================
+ Hits 799 852 +53
+ Misses 1057 1011 -46 ☔ View full report in Codecov by Sentry. |
|
ready to merge |
|
bump |
mcabbott
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't officially support Enzyme yet, but since we are going to in the future we better start testing, see what is missing, and watch out for regressions.
The testing work has already started at EnzymeAD/Enzyme.jl#805, here I mostly copy some of the tests contributed by @jgreener64 so that they become part of Flux's testsuite.
Related issues in Enzyme.jl:
PRs in CUDA.jl: