Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cells' return to out, state #2551

Merged
merged 7 commits into from
Dec 15, 2024
Merged

Change cells' return to out, state #2551

merged 7 commits into from
Dec 15, 2024

Conversation

CarloLucibello
Copy link
Member

This is what proposal 2 in #2548 looks like.
If we do it, we should do it as soon as possible since this requires tagging v0.16.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 32.50%. Comparing base (6041cf5) to head (55fe124).

Files with missing lines Patch % Lines
src/layers/recurrent.jl 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2551      +/-   ##
==========================================
- Coverage   32.53%   32.50%   -0.04%     
==========================================
  Files          34       34              
  Lines        2010     2003       -7     
==========================================
- Hits          654      651       -3     
+ Misses       1356     1352       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarloLucibello CarloLucibello changed the title Chance cells' return to out, state Change cells' return to out, state Dec 12, 2024
@CarloLucibello CarloLucibello merged commit 0683976 into master Dec 15, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant