Scope self arguments using let block syntax

[gaurav-arya]

This PR is on top of #16 to avoid merge conflcits, but the only changes are f1aeaf3 and c1f6605

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.26% 🎉

Comparison is base (9dcae27) 78.64% compared to head (9ab4b87) 79.90%.

❗ Current head 9ab4b87 differs from pull request most recent head 6da9002. Consider uploading reports for the commit 6da9002 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   78.64%   79.90%   +1.26%     
==========================================
  Files           6        6              
  Lines         206      219      +13     
==========================================
+ Hits          162      175      +13     
  Misses         44       44              

Files Changed	Coverage Δ
src/compact.jl	93.40% <100.00%> (+1.09%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mcabbott]

This basically seems fine to me. Nicely seen, I only thought of the syntax transformation.

I think this shouldn't break any cases which now work.

[MilesCranmer]

Btw, can we remove the outer let .. end block in the macro output?

Fluxperimental.jl/src/compact.jl

Lines 135 to 139 in 4572f6e

	return esc(quote
	let
	$CompactLayer($fex, $name, ($layer, $input, $block), $setup; $(kwexs...))
	end
	end)

This was only needed when we were doing the variable assignments with it, right? Or does it still serve a purpose?

[gaurav-arya]

Comments should be addressed now 🙂