-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix MLP #194
fix MLP #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks indeed.
Oops, I have approved, but tests are not passing.
@jbrea Can you make a trivial commit to re-trigger buildkite? I think tests should pass now. |
Codecov Report
@@ Coverage Diff @@
## dev #194 +/- ##
==========================================
+ Coverage 88.97% 92.27% +3.29%
==========================================
Files 9 9
Lines 245 246 +1
==========================================
+ Hits 218 227 +9
+ Misses 27 19 -8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Otherwise there is the following error