Rethrow the error caught when builder fails #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## dev #238 +/- ##
==========================================
- Coverage 92.06% 91.45% -0.61%
==========================================
Files 12 12
Lines 315 316 +1
==========================================
- Hits 290 289 -1
- Misses 25 27 +2
☔ View full report in Codecov by Sentry. |
|
@OkonSamuel Could you please review this? I've sent you an contributor invitation. |
OkonSamuel
requested changes
Sep 4, 2023
|
I've added a test. |
Co-authored-by: Okon Samuel <39421418+OkonSamuel@users.noreply.github.com>
|
I think we can ignore the nightly fail. @OkonSamuel Are you happy for a merge? |
OkonSamuel
approved these changes
Sep 5, 2023
This was referenced Sep 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #237
There is presently a
throw-catchblock to check a user-provided builder will successfully create a Flux model. This PR ensures that the exception causing the fail is ultimately thrown.