-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve some activation function gradients #392
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3a59715
add a few more activation rules
mcabbott a94b679
nicer grad inference test
mcabbott d193741
other testing cleanup
mcabbott 2c2ec78
actually test binary rules
mcabbott f64fd9f
only allow x2::Number, and switch to NaN
mcabbott b282435
add non-gradient tests for binary activations
mcabbott c3a405f
second derivative tests
mcabbott 81f4e06
docstrings
mcabbott 9648c46
more gradients
mcabbott 4f59c3c
faster
mcabbott ad3a9f6
notation
mcabbott 47084e9
one correction
mcabbott File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What rules like this don't solve is that you need to change
Dense(10 => 20, lekyrelu)
intoto provide the 2nd argument.
Not this PR, but it would be nice if you could write
Dense(10 => 20, lekyrelu(0.1))
instead. Perhaps it has to beDense(10 => 20, Lekyrelu(0.1))
with some new struct, but perhaps you can just be clever with overloadingbroadcasted
so thatlekyrelu(0.1)
makes a function butDense(10 => 20, lekyrelu)
doesn't create a vector of functions?