Add group support for convolutions #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this need to be rebased on NNlib? |
|
Not sure why? |
|
Sorry I misspoke, I didn't mean rebase, but depend on nnlib#master for ci to pick up the latest code. Otherwise LGTM! |
|
Also, should there be a release for NNlib, before this PR can be merged? |
DhairyaLGandhi
approved these changes
Jul 16, 2021
Co-authored-by: Dhairya Gandhi <dhairya@juliacomputing.com>
|
NNlib 0.7.25 is in the process of being registered. The compat bound in Project.toml should be updated here |
test/conv.jl
Outdated
| end | ||
| gputest(NNlibCUDA.∇conv_bias!, db, dy, checkgrad=false) |
There was a problem hiding this comment.
would you mind removing the function and test from here?
There was a problem hiding this comment.
the function is needed to test the gpu method of the same function we have in NNlibCUDA
There was a problem hiding this comment.
So do we keep the test and function?)
|
I had to add a dummy commit to retrigger buildkite |
|
buildkite didn't pick up the new NNlib version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for groups in convolutions. It relies on this PR, so I'll mark it as draft for now.