Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing new support for asymmetrical padding #19

Open
IanButterworth opened this issue Apr 10, 2019 · 3 comments
Open

Implementing new support for asymmetrical padding #19

IanButterworth opened this issue Apr 10, 2019 · 3 comments

Comments

@IanButterworth
Copy link

With FluxML/Flux.jl#718 flux now supports asymmetrical padding, so it would be great to be able to support ONNX models that use asymmetrical padding, such as YOLOv2 (YOLOv3 uses symmetrical padding, I believe)
@ayush1999
Copy link
Collaborator

It'd be great to try out the models we previously couldn't. There's been a lot of refactoring going on in Flux/NNlib. This includes asymmetric pads/LRN layer and CrossCor for Flux. I'll make all the required changes in this package once these PRs are merged.

@ayush-1506
Copy link
Member

@ianshmean I've made a few basic changes (asymmetric padding, CrossCor). Feel free to go ahead and try these out. (Please open an issue in case there's something wrong/missing.)

@IanButterworth
Copy link
Author

Great! I will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@IanButterworth @ayush1999 @ayush-1506