-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add asymmetric padding #718
Conversation
May as well fold into #714? |
Sure, if you like, just close #714 and merge this one when FluxML/Tracker.jl#11 is merged. |
6befd74
to
052e661
Compare
052e661
to
a81036c
Compare
@MikeInnes looks like we're good to go, merge at your leisure. |
Thanks a lot @staticfloat. I suspect it'd be cleaner to store the |
I thought of that, but considering that we need to re-create it for every differently-sized |
Ah yes, I didn't realise you're actually including the size of the input. This is probably the right way to do it then. |
This goes on top of #714, since NNlib now has support for asymmetrical padding this provides the Flux-level API for it.