Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asymmetric padding #718

Merged
merged 5 commits into from
Apr 25, 2019
Merged

Add asymmetric padding #718

merged 5 commits into from
Apr 25, 2019

Conversation

staticfloat
Copy link
Contributor

This goes on top of #714, since NNlib now has support for asymmetrical padding this provides the Flux-level API for it.

@MikeInnes
Copy link
Member

May as well fold into #714?

@staticfloat
Copy link
Contributor Author

Sure, if you like, just close #714 and merge this one when FluxML/Tracker.jl#11 is merged.

@staticfloat staticfloat force-pushed the sf/asymmetric_padding branch 2 times, most recently from 6befd74 to 052e661 Compare April 25, 2019 17:06
@staticfloat staticfloat force-pushed the sf/asymmetric_padding branch from 052e661 to a81036c Compare April 25, 2019 17:11
@staticfloat
Copy link
Contributor Author

@MikeInnes looks like we're good to go, merge at your leisure.

@MikeInnes
Copy link
Member

Thanks a lot @staticfloat.

I suspect it'd be cleaner to store the Dims object in the layer, rather than storing the same settings and reconstructing it on the fly. But that's not important for now.

@MikeInnes MikeInnes merged commit 13cfcb5 into master Apr 25, 2019
@staticfloat
Copy link
Contributor Author

I suspect it'd be cleaner to store the Dims object in the layer,

I thought of that, but considering that we need to re-create it for every differently-sized x, it wasn't high on my priority list. It may save us a little bit of time, but not that much. :P

@MikeInnes
Copy link
Member

Ah yes, I didn't realise you're actually including the size of the input. This is probably the right way to do it then.

@CarloLucibello CarloLucibello deleted the sf/asymmetric_padding branch April 7, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants