-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule for gradient accumulation #137
Conversation
test/rules.jl
Outdated
x0 = rand(5) | ||
x = copy(x0) | ||
lr = 0.01 | ||
tree = Optimisers.setup(AccumGrad(Descent(lr), 3), x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A torture test would use something with a large momentum, so that it fails if the rule is applied 3 times, rather that once for the total gradient. But not sure that's necessary.
Co-authored-by: Michael Abbott <32575566+mcabbott@users.noreply.github.com>
|
||
|
||
""" | ||
AccumGrad(n::Int) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo for rendering
AccumGrad(n::Int) | |
AccumGrad(n::Int) |
Fix #130
PR Checklist