Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add trainables_with_path #173

Closed
wants to merge 5 commits into from
Closed

add trainables_with_path #173

wants to merge 5 commits into from

Conversation

CarloLucibello
Copy link
Member

continuation of #171, to be merged after that.

@CarloLucibello
fix broken documentation (#172)
b4920f7 
* fix docs

* cleanup
@darsnack darsnack mentioned this pull request Apr 4, 2024
Merged
4 tasks
@CarloLucibello
add trainables (#171)
a87ffd5 
* trainables

* trainables

* cl/trainables

* trainables

* test second order derivatives

* add doc section

* fix test

* Update src/trainables.jl
@CarloLucibello
Copy link
Member Author

In #171 (comment) @darsnack said

Also, while okay for Functors, I'm not a fan of duplicated *_with_path functions. Like @ToucheSir suggested, if we want two variants, then a keyword flag seems like a better API.

If we are not concerned with type instability and performance issues I agree that a flag would be better.

@ToucheSir
Copy link
Member

I think the implementation is already type unstable, so I wouldn't be concerned. Making a method with kwargs type stable would be easy compared to making all of the internals type stable, even under AD.

@CarloLucibello
Copy link
Member Author

I don't understand how to switch this PR to target master, I'll open a new one

@CarloLucibello CarloLucibello mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarloLucibello @ToucheSir