Add docs #19
Merged
Add docs #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
reviewed
Jul 21, 2021
Co-authored-by: Brian Chen <ToucheSir@users.noreply.github.com>
|
We should add some starting docs, we have API docs already, but maybe we should pull some out of Flux already? |
|
I think that's better served by a follow-up PR, since getting the site up will allow us more time to work on other docs stuff. Are the failures on nightly expected or do they need to be resolved here? |
|
Nightly seems to started failing recently but I think that's an upstream issue which would get resolved soon. I hope in the meanwhile that we test out against 1.7 which is much more pressing IMO. |
ToucheSir
approved these changes
Jul 30, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and some other house keeping chores.