Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nothing grads for Pairs.data #1295

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Conversation

ToucheSir
Copy link
Member

@ToucheSir ToucheSir commented Aug 26, 2022

MWE:

no_kwarg_grad(x; kwargs...) = x[kwargs[:i]]
gradient(x -> no_kwarg_grad(x; i=1), [1]) # MethodError: no method matching getindex(::Nothing, ::Int64) on master

@ChrisRackauckas it also appears that whatever SciMLSensitivity downstream tests are running are inadequate to catch stuff like this. In fact, I'm not sure if any are running given that file still reads DiffEqFlux. What should we replace that line with?

@ChrisRackauckas
Copy link
Member

It's just in a different test group. #1296

@ChrisRackauckas
Copy link
Member

Bump?

@ToucheSir ToucheSir merged commit 0ede287 into master Aug 29, 2022
@ToucheSir ToucheSir deleted the bc/kwargs-getindex-nokeygrad branch August 29, 2022 22:21
@ToucheSir
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants