MethodError if configured rrule is ambiguous #1358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1342
which is a special case of ambiguity where the ambiguity is for a configured rule and it's configured opt-out.
But it applies without an opt-out also.
This in particular implements Sol0
Which is to give an useful
MethodError
rather than a confusing error about no field, as follows:Before
Now:
This behavior is consistent with our behavour for non-configured rules as implemented in #1342
Sol1 (to just ignore rules) would be easily implemented for both configured and unconfigured cases by changing the final
if
tois_ambig || match(...)
rather than `!is_ambig && match(...)but should be a separate PR.
PR Checklist