Use BasicKeyValuePair and UrlEncode

[agnel]

Why do you hard code the data and then url encode it?
Instead you should use the BasicKeyValuePair and a UrlEncoder Class.

[FoamyGuy]

Definitely a good suggestion. I will get that updated whenever I have a chance to, but it could be a while. If you want to create a fork and make that change I would gladly pull it in =)

[agnel]

Also one more thing you do not check whether there is a data connection available via the 2G/3G/WiFi for sending the data!

[FoamyGuy]

Another great point. Same deal I'll try to fix it when I can, but if you'd like to fork and do that I will pull it in.

[agnel]

Try integrating it with the Crouton or AppMsg or MessageBar library for
notifying user about the results (like whether it was successfully sent or
failed ).
On Jul 8, 2014 8:14 PM, "FoamyGuy" notifications@github.com wrote:

Another great point. Same deal I'll try to fix it when I can, but if you'd
like to fork and do that I will pull it in.

—
Reply to this email directly or view it on GitHub
#1 (comment)
.

[agnel]

You implemented this in an activity, Ever given a thought about implementing in Fragments(like ViewPager) ?

[FoamyGuy]

I haven't for this app since it is just a bare bones example of submitting data to the spreadsheet.