Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented support for ValueTask #105

Merged
merged 1 commit into from Oct 25, 2019
Merged

Implemented support for ValueTask #105

merged 1 commit into from Oct 25, 2019

Conversation

blankensteiner
Copy link
Contributor

ValueTask is available for both .NET Standard 2.0 and 2.1, meaning that it is used by both .NET Core and .NET Framework. Only having support for Task is problematic and therefore we have added support for ValueTask also.

@SimonCropp
Copy link
Member

@blankensteiner thanks. i will look at this over the weekend.

BTW did you and you dev team forget to sign up to be patrons? https://github.com/Fody/Home/blob/master/pages/licensing-patron-faq.md#do-i-need-to-be-a-patron-to-contribute-a-pull-request

@SimonCropp SimonCropp added this to the 3.3.0 milestone Oct 25, 2019
@SimonCropp SimonCropp merged commit 154c2b5 into Fody:master Oct 25, 2019
@SimonCropp
Copy link
Member

This is now deployed. NuGet may take some time to make it available for download.

@blankensteiner
Copy link
Contributor Author

Btw, in regards to becoming a Patron, we (in Danske Commodities) just started using Fody this week and my manager is on paternity leave until mid November. Will talk to him the first chance I get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants