This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
Removing forced unwrapping #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigorsa
force-pushed
the
housekeeping/removing-forced-unwrapping
branch
from
00f7721 to
0db0713
Compare
| } | ||
|
|
||
| var activeClass: String { | ||
| guard let className = metadata.findMetaByProperty("media:active-class") else { | ||
| guard let className = metadata.find(byProperty: "media:active-class")?.value else { |
There was a problem hiding this comment.
I don't get why use .value here and not wrap it in the function as it was before.
There was a problem hiding this comment.
Since metadata is an object it does not make sense a method named findMetaByProperty() or find(byProperty:) returns a String. In the previous implementation there were two methods named findMetaByName and findMetaByProperty and they were returning different "contents" that is weird. I guess now these method are more consistent and the developer can choose witch Meta's property is better to use
| return "epub-media-overlay-active" | ||
| } | ||
| return className | ||
| } | ||
|
|
||
| var playbackActiveClass: String { | ||
| guard let className = metadata.findMetaByProperty("media:playback-active-class") else { | ||
| guard let className = metadata.find(byProperty: "media:playback-active-class")?.value else { |
There was a problem hiding this comment.
Same here and in the others that use .value
There was a problem hiding this comment.
The same as above
hebertialmeida
approved these changes
Jan 12, 2018
| } | ||
|
|
||
| var activeClass: String { | ||
| guard let className = metadata.findMetaByProperty("media:active-class") else { | ||
| guard let className = metadata.find(byProperty: "media:active-class")?.value else { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.