Skip to content

Commit

Permalink
- Remove Unicode vapi, which was used to work around intermittent bui…
Browse files Browse the repository at this point in the history 
…ld failures.
  • Loading branch information
@JerryCasiano
JerryCasiano committed Mar 22, 2021
1 parent c7e2cd3 commit 10171c6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 139 deletions.
2 changes: 1 addition & 1 deletion lib/common/meson.build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -87,5 +87,5 @@ common_vapi = gnome.generate_vapi('font-manager-common',
'json-glib-1.0',
'libxml-2.0',
'sqlite3',
'Unicode'
'Unicode-@0@'.format(meson.project_version())
])
138 changes: 0 additions & 138 deletions lib/unicode/Unicode.vapi
View file

This file was deleted.

9 comments on commit 10171c6

@PF4Public
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really not needed anymore?

[69/119] /usr/bin/vapigen-0.48 --quiet --library=font-manager-common --directory=/var/tmp/portage/app-misc/font-manager-0.8.5/work/font
-manager-0.8.5-build/lib/common --vapidir=/var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-0.8.5-build/lib/common --vapid
ir=/var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-0.8.5-build/lib/unicode --vapidir=/var/tmp/portage/app-misc/font-mana
ger-0.8.5/work/font-manager-0.8.5/lib/unicode --metadatadir=/var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-0.8.5-build/
lib/common --pkg=glib-2.0 --pkg=gio-2.0 --pkg=gdk-3.0 --pkg=gtk+-3.0 --pkg=json-glib-1.0 --pkg=libxml-2.0 --pkg=sqlite3 --pkg=Unicode-0
.8.5 --metadatadir=/var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-0.8.5/lib/common /var/tmp/portage/app-misc/font-manag
er-0.8.5/work/font-manager-0.8.5-build/lib/common/FontManager-0.8.5.gir /var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-
0.8.5-build/lib/unicode/Unicode-0.8.5.gir /var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-0.8.5/lib/common/font-manager-
common.vala
FAILED: lib/common/font-manager-common.vapi
/usr/bin/vapigen-0.48 --quiet --library=font-manager-common --directory=/var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-
0.8.5-build/lib/common --vapidir=/var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-0.8.5-build/lib/common --vapidir=/var/t
mp/portage/app-misc/font-manager-0.8.5/work/font-manager-0.8.5-build/lib/unicode --vapidir=/var/tmp/portage/app-misc/font-manager-0.8.5
/work/font-manager-0.8.5/lib/unicode --metadatadir=/var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-0.8.5-build/lib/commo
n --pkg=glib-2.0 --pkg=gio-2.0 --pkg=gdk-3.0 --pkg=gtk+-3.0 --pkg=json-glib-1.0 --pkg=libxml-2.0 --pkg=sqlite3 --pkg=Unicode-0.8.5 --me
tadatadir=/var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-0.8.5/lib/common /var/tmp/portage/app-misc/font-manager-0.8.5/
work/font-manager-0.8.5-build/lib/common/FontManager-0.8.5.gir /var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-0.8.5-bui
ld/lib/unicode/Unicode-0.8.5.gir /var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-0.8.5/lib/common/font-manager-common.vala
error: Package `Unicode-0.8.5' not found in specified Vala API directories or GObject-Introspection GIR directories
[70/119] /usr/bin/vapigen-0.48 --quiet --library=Unicode-0.8.5 --directory=/var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-0.8.5-build/lib/unicode --metadatadir=/var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-0.8.5-build/lib/unicode --pkg=glib-2.0 --pkg=pango --pkg=gdk-3.0 --pkg=gtk+-3.0 --metadatadir=/var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-0.8.5/lib/unicode /var/tmp/portage/app-misc/font-manager-0.8.5/work/font-manager-0.8.5-build/lib/unicode/Unicode-0.8.5.gir
ninja: build stopped: subcommand failed.

@PF4Public
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, looks like it is a race condition or something, as it worked on the second and the third run.

@JerryCasiano
Copy link
Contributor Author

@JerryCasiano JerryCasiano commented on 10171c6 Mar 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what it is.

Haven't been able to figure out the root cause.
But to be honest I didn't invest much time to try to figure it out, I just worked around it.

It manifests more often when using the -C option to ninja. Not so much when running from the build directory.

I'll look into it. Just not sure if it's a meson bug or something in our build files... leaning towards a meson bug though.

@PF4Public
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it deserve to be an issue?

@JerryCasiano
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably.

Worst case scenario I can add the file back and tag a point release.

@PF4Public
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest me filing a new issue and you're taking your time. :D

This way we may catch "Me too"'s and kind of measure the impact and urgency of this issue.

Sounds good?

@JerryCasiano
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds right to me.

I can't actually reproduce this on my machine at this point so if other people +1 the issue I'll probably just ship the generated vapi file again. I remember I did that to workaround build failures on Launchpad.

@PF4Public
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a true Heisenbug. Ever after the first failed attempt I couldn't reproduce it even gradually increasing -j up to 500.

@JerryCasiano
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. That's why I ended up just working around it, it's so random.

Main problem is how do we know if we fixed it...

Please sign in to comment.