Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature suggestion] Filter fonts (beyond filtering typefaces) #316

Closed
noyannus opened this issue Mar 22, 2023 · 6 comments
Closed

[Feature suggestion] Filter fonts (beyond filtering typefaces) #316

noyannus opened this issue Mar 22, 2023 · 6 comments
Milestone

Comments

@noyannus
Copy link

The filtering could be extended to finer granularity and work on individual fonts, beyond filtering typefaces (font families). See below; it shows a test collection with the DejaVu families.

Screenshot_2023-03-22_08:30:05

Screenshot_2023-03-22_08:30:56

Screenshot_2023-03-22_08:31:23

Screenshot_2023-03-22_08:31:39

Screenshot_2023-03-22_08:31:55

Screenshot_2023-03-22_08:32:08

@JerryCasiano
Copy link
Contributor

wip-gtk4 contains some changes related to this.

I'll see if backporting is a possibility otherwise this will get punted to 0.9 milestone.

@JerryCasiano
Copy link
Contributor

JerryCasiano commented Mar 22, 2023

Unfortunately it looks like backporting is not going to be quick and easy.

The GTK 4 port is not perfect either but it does seem to already work better in this regard.

bold_search
oblique_search
semi_search

Sorry, but it'll probably be a while on this. Aside from serious bugs or quick and easy fixes the focus of development is now squarely on the GTK 4 port, so I'm punting this till that releases.

We can keep this open as a motivator.

@JerryCasiano JerryCasiano added this to the 1.0 milestone Mar 22, 2023
@noyannus
Copy link
Author

Great! I'm looking forward to the GTK 4 release!

The following is not worth an issue of itself, imo:

The search field could be auto expanding with pane width to be very broad, or at least have a much larger fixed width. You'd get a fair gain in functionality for a small aesthetic cost.

To demonstrate with an example, users might want to see at a glance whether they are searching for
DejaVuSansMono Nerd Font Mono Bold, or for
DejaVuSansMono Nerd Font Mono Bold Oblique,
but now see only truncated bits from DejaVuSansM to old Oblique. And there may exist even longer font [family] names or character widths.

@JerryCasiano
Copy link
Contributor

The search field could be auto expanding with pane width to be very broad, or at least have a much larger fixed width. You'd get a fair gain in functionality for a small aesthetic cost.

Well, aesthetics are important, not as important as function of course but still an important consideration.

To demonstrate with an example, users might want to see at a glance whether they are searching for
DejaVuSansMono Nerd Font Mono Bold, or for
DejaVuSansMono Nerd Font Mono Bold Oblique,
but now see only truncated bits from DejaVuSansM to old Oblique. And there may exist even longer font [family] names or character widths.

I'm not sure searching for that long and detailed of a string is a very common scenario. At least not common enough to justify making the search entry larger.

In any case, the GTK 4 port will allow for matching chunks so that should prevent such overflow without making the search field huge at all times and still allow you to drill down pretty far. ;-)

less_typing

much_less_typing

@noyannus
Copy link
Author

Well, aesthetics are important, not as important as function of course but still an important consideration.

Not arguing with that. Decades with macs as main production machines (I'm migrating right now) made me appreciate a well thought out design and user experience very much. But also, that sometimes ease of function > good looks. I'm very happy to see both in the upcoming versions.

I'm not sure searching for that long and detailed of a string is a very common scenario. At least not common enough to justify making the search entry larger.

In any case, the GTK 4 port will allow for matching chunks so that should prevent such overflow without making the search field huge at all times and still allow you to drill down pretty far. ;-)

The best of both worlds. Thanks for the time you took to explain!

@JerryCasiano
Copy link
Contributor

I'm closing this out now as it's been completed in the WIP branch for a while now and will be part of the next release.

Thanks again.

JerryCasiano added a commit that referenced this issue Jun 16, 2024
- Closes #297
- Closes #316
- Closes #250
- Closes #332
- Closes #330
- Closes #349
- Closes #319
- Closes #286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants