-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV-19117 Upgrade .NET from 6.0.21 to 6.0.22 #29
Conversation
@@ -2,6 +2,8 @@ | |||
|
|||
<PropertyGroup> | |||
<TargetFramework>net6.0</TargetFramework> | |||
<RuntimeFrameworkVersion>6.0.22</RuntimeFrameworkVersion> | |||
<Version>7.0.0</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the <Version>7.0.0</Version>
it is not needed for the dotnet upgrade and we don't need to specify version yet in the stage we're at imo
PrscSharp/PrscSharp.csproj
Outdated
@@ -2,6 +2,8 @@ | |||
|
|||
<PropertyGroup> | |||
<TargetFramework>net6.0</TargetFramework> | |||
<RuntimeFrameworkVersion>6.0.22</RuntimeFrameworkVersion> | |||
<Version>7.0.0</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
@@ -3,6 +3,8 @@ | |||
<PropertyGroup> | |||
<OutputType>Exe</OutputType> | |||
<TargetFramework>net6.0</TargetFramework> | |||
<RuntimeFrameworkVersion>6.0.22</RuntimeFrameworkVersion> | |||
<Version>7.0.0</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
XPathRunner/XPathRunner.csproj
Outdated
@@ -3,6 +3,8 @@ | |||
<PropertyGroup> | |||
<OutputType>Exe</OutputType> | |||
<TargetFramework>net6.0</TargetFramework> | |||
<RuntimeFrameworkVersion>6.0.22</RuntimeFrameworkVersion> | |||
<Version>7.0.0</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
XPathTest/XPathTest.csproj
Outdated
@@ -2,8 +2,9 @@ | |||
|
|||
<PropertyGroup> | |||
<TargetFramework>net6.0</TargetFramework> | |||
<RuntimeFrameworkVersion>6.0.22</RuntimeFrameworkVersion> | |||
<Version>7.0.0</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting the same changes as @JosVerburg reported regarding not needing to include the <Version>
elements.
5861b23
to
f2618eb
Compare
It's merged.. but seems GitHub is not a fan of me merging locally instead of using the merge button ¯_(ツ)_/¯ |
No description provided.