Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-19117 Upgrade .NET from 6.0.21 to 6.0.22 #29

Closed
wants to merge 1 commit into from

Conversation

mtesseracttech
Copy link
Collaborator

No description provided.

@@ -2,6 +2,8 @@

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<RuntimeFrameworkVersion>6.0.22</RuntimeFrameworkVersion>
<Version>7.0.0</Version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the <Version>7.0.0</Version> it is not needed for the dotnet upgrade and we don't need to specify version yet in the stage we're at imo

@@ -2,6 +2,8 @@

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<RuntimeFrameworkVersion>6.0.22</RuntimeFrameworkVersion>
<Version>7.0.0</Version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

@@ -3,6 +3,8 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<RuntimeFrameworkVersion>6.0.22</RuntimeFrameworkVersion>
<Version>7.0.0</Version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

@@ -3,6 +3,8 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<RuntimeFrameworkVersion>6.0.22</RuntimeFrameworkVersion>
<Version>7.0.0</Version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

@@ -2,8 +2,9 @@

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<RuntimeFrameworkVersion>6.0.22</RuntimeFrameworkVersion>
<Version>7.0.0</Version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

Copy link
Member

@Erikvl87 Erikvl87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting the same changes as @JosVerburg reported regarding not needing to include the <Version> elements.

@JosVerburg JosVerburg closed this Sep 15, 2023
@JosVerburg JosVerburg deleted the DEV-19117 branch September 15, 2023 09:49
@JosVerburg
Copy link
Member

It's merged.. but seems GitHub is not a fan of me merging locally instead of using the merge button ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants