Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Rust toolchain version to 1.81.0 #1763

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Pin Rust toolchain version to 1.81.0 #1763

merged 1 commit into from
Oct 19, 2024

Conversation

FooIbar
Copy link
Owner

@FooIbar FooIbar commented Oct 19, 2024

1.82.0 has a severe binary size regression (+36%)

    FILE SIZE        VM SIZE
 --------------  --------------
   +44%  +131Ki   +44%  +131Ki    .text
   +30% +10.7Ki   +30% +10.7Ki    .eh_frame
  +6.6% +2.82Ki  +6.6% +2.82Ki    .rodata
   +11% +2.58Ki   +11% +2.58Ki    .rela.dyn
   +16% +2.41Ki   +16% +2.41Ki    .data.rel.ro
  +190% +2.39Ki  +190% +2.39Ki    .gcc_except_table
   +22% +1.29Ki   +22% +1.29Ki    .eh_frame_hdr
   +16%    +176   +16%    +176    .rela.plt
   +12%    +168   +12%    +168    .dynsym
   +14%    +112   +14%    +112    .plt
   +14%     +56   +14%     +56    .got.plt
   +40%     +48   +40%     +48    .data
  +1.9%     +24  +1.9%     +24    .dynstr
   +14%     +16   +14%     +16    .gnu.version
  [ = ]       0  -0.3%      -8    .bss
  -3.6%     -16  -3.6%     -16    .dynamic
  [ = ]       0 -81.4% -2.36Ki    .relro_padding
   +36%  +154Ki   +35%  +152Ki    TOTAL

1.82.0 has a severe binary size regression (+36%)
@FooIbar FooIbar requested a review from revonateB0T October 19, 2024 08:46
Copy link
Collaborator

@revonateB0T revonateB0T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream issue link?

@FooIbar
Copy link
Owner Author

FooIbar commented Oct 19, 2024

Upstream issue link?

rust-lang/rust#130320

@FooIbar FooIbar merged commit 9e410a6 into main Oct 19, 2024
4 checks passed
@FooIbar FooIbar deleted the fb/rust branch October 19, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants