This repository has been archived by the owner on Feb 25, 2023. It is now read-only.
Fix incorrect furigana distribution #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toasted-nutbread
added a commit
that referenced
this pull request
Mar 11, 2021
* Improve distributeFuriganaInflected implementation * Update tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1509.
distributeFuriganaInflecteddid not properly handle cases where the source matches the reading instead of the expression.Prior to #1496, this only incidentally seemed to work. The bug that was fixed in that commit was causing an apparently correct, but still broken, behaviour of this function.