Paddlebox Fix calculate_bucket_error (PaddlePaddle#24)

ForFishes · Jun 20, 2020 · 632825d · 632825d
1 parent 9812cc1
commit 632825d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/paddle/fluid/framework/fleet/box_wrapper.cc b/paddle/fluid/framework/fleet/box_wrapper.cc
@@ -71,6 +71,8 @@ void BasicAucCalculator::compute() {
   _actual_ctr = tp / (fp + tp);
 
   _size = fp + tp;
+
+  calculate_bucket_error();
 }
 
 void BoxWrapper::CheckEmbedSizeIsValid(int embedx_dim, int expand_embed_dim) {

diff --git a/paddle/fluid/framework/fleet/box_wrapper.h b/paddle/fluid/framework/fleet/box_wrapper.h
@@ -101,6 +101,8 @@ class BasicAucCalculator {
   double& local_abserr() { return _local_abserr; }
   double& local_sqrerr() { return _local_sqrerr; }
   double& local_pred() { return _local_pred; }
+
+ private:
   void calculate_bucket_error();
 
  protected:
@@ -668,7 +670,6 @@ class BoxWrapper {
                           "The metric name you provided is not registered."));
     std::vector<float> metric_return_values_(8, 0.0);
     auto* auc_cal_ = iter->second->GetCalculator();
-    auc_cal_->calculate_bucket_error();
     auc_cal_->compute();
     metric_return_values_[0] = auc_cal_->auc();
     metric_return_values_[1] = auc_cal_->bucket_error();