Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StandardColorParsers::Dictionary: make readonly #358

Closed
Tracked by #343
ForNeVeR opened this issue Feb 1, 2023 · 0 comments · Fixed by #372
Closed
Tracked by #343

StandardColorParsers::Dictionary: make readonly #358

ForNeVeR opened this issue Feb 1, 2023 · 0 comments · Fixed by #372
Labels
help-wanted kind:refactoring

Comments

@ForNeVeR
Copy link
Owner

ForNeVeR commented Feb 1, 2023 •
edited
Loading

Right now, StandardColorParsers::Dictionary is a public static writable field, which is a mistake.

Should be made readonly, even if this change is breaking.

Look for TODO[#358] to find it in the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help-wanted kind:refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor API cleanup ForNeVeR/xaml-math
1 participant
@ForNeVeR