Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nullable reference types #277

Merged
merged 23 commits into from
Aug 16, 2020
Merged

Enable nullable reference types #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
f9d075b
Enable nullable reference types
ygra Aug 13, 2020
921fe88
Drop nullable disable flags for WpfMath.Colors.
ygra Aug 13, 2020
6bdc348
Drop nullable diable for SvgConverter.
ygra Aug 13, 2020
ff0c861
Drop nullable disable for Utils.
ygra Aug 13, 2020
06fe829
Fixed nullable reference types in sample app.
ygra Aug 14, 2020
fe99f63
Drop nullable disable on a few Tex* classes.
ygra Aug 14, 2020
fc3a7c1
Drop nullable disable on a few more files.
ygra Aug 14, 2020
261695e
Drop nullable disable for Matrices folder.
ygra Aug 14, 2020
f43f6c2
Drop nullable disable for Rendering folder.
ygra Aug 14, 2020
b9ecf56
Drop nullable disable for exceptions.
ygra Aug 14, 2020
290de97
Drop nullable disable for controls.
ygra Aug 14, 2020
7f55098
Drop nullable disable for Glue classes.
ygra Aug 14, 2020
33384cd
Drop nullable disable in Parsers folder.
ygra Aug 14, 2020
5e34df8
Drop nullable disable on first half of Atoms.
ygra Aug 14, 2020
b38d86e
Drop nullable disable on second half of Atoms.
ygra Aug 14, 2020
021704e
Drop nullable disable on third half of Atoms.
ygra Aug 14, 2020
d477cce
Drop nullable disable in RowAtom.
ygra Aug 14, 2020
2314ecc
Drop nullable disable for Box classes.
ygra Aug 14, 2020
6586f26
Drop nullable disable on TexFormulaParser.
ygra Aug 14, 2020
4717e58
Made nullability attributes conditional.
ygra Aug 15, 2020
b6582a3
Review fixes.
ygra Aug 15, 2020
ff1bbfa
Rollback of null handling in RowAtom.
ygra Aug 15, 2020
5b4fd21
Fixed tests after removal of IsDefaultStyle.
ygra Aug 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/WpfMath.Example/App.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public partial class App : Application
{
public static new App Current
{
get { return Application.Current as App; }
get { return (App) Application.Current; }
}

private void Application_Startup(object sender, StartupEventArgs e)
Expand Down
4 changes: 2 additions & 2 deletions src/WpfMath.Example/MainWindow.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ public MainWindow()
FormulaSelector.SelectedIndex = 0;
}

private TexFormula ParseFormula(string input)
private TexFormula? ParseFormula(string input)
{
// Create formula object from input text.
TexFormula formula = null;
TexFormula? formula = null;
try
{
formula = this._formulaParser.Parse(input);
Expand Down
9 changes: 8 additions & 1 deletion src/WpfMath.Example/WpfMath.Example.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,15 @@
<UseWpf>true</UseWpf>
<DebugType>Full</DebugType>
<IsPackable>false</IsPackable>
<Nullable>enable</Nullable>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="../WpfMath/WpfMath.csproj"/>
<ProjectReference Include="../WpfMath/WpfMath.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Nullable" Version="1.2.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
</ItemGroup>
</Project>
2 changes: 0 additions & 2 deletions src/WpfMath.Tests/TestResults/ParserTests.2+2.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
{
"Character": "2",
"TextStyle": null,
"IsDefaultTextStyle": true,
"IsTextSymbol": false,
"Type": "Ordinary",
"Source": {
Expand All @@ -33,7 +32,6 @@
{
"Character": "2",
"TextStyle": null,
"IsDefaultTextStyle": true,
"IsTextSymbol": false,
"Type": "Ordinary",
"Source": {
Expand Down
Loading