Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for empty delimiters #58

Merged
merged 3 commits into from
Feb 26, 2017
Merged

Support for empty delimiters #58

merged 3 commits into from
Feb 26, 2017

Conversation

ForNeVeR
Copy link
Owner

@ForNeVeR ForNeVeR commented Feb 26, 2017

That's the last piece of #14. It allows to do things like this:

image

We already support rendering of FencedAtom with either LeftDelimiter or RightDelimiter being defined as null, so I've decided that we should construct it so when any delimiter is omitted.

Although our parser isn't null-tolerant at all, and I don't think it should be. So, parser generates symbols with a special names, and those get replaced when constructing the FencedAtom.

I've used another solution without abusing null values.

Closes #14.

@ForNeVeR ForNeVeR self-assigned this Feb 26, 2017
@ForNeVeR ForNeVeR changed the title [WIP] Support for empty delimiters Support for empty delimiters Feb 26, 2017
Copy link
Collaborator

@gsomix gsomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check this example: "\left x \right."? It fails with ArgumentNullException.

@gsomix
Copy link
Collaborator

gsomix commented Feb 26, 2017

@ForNeVeR, also "\left. x \right y".

@ForNeVeR
Copy link
Owner Author

@gsomix that was fixed.

Copy link
Collaborator

@gsomix gsomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, 🐐

@ForNeVeR ForNeVeR merged commit 9236db2 into master Feb 26, 2017
@ForNeVeR ForNeVeR deleted the feature/14-empty-delimiter branch February 26, 2017 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants