SVG: Added support for curves and removed flattening of the geometry #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsomix
approved these changes
Apr 8, 2017
|
Old part of the sigma sign (first) vs. the newer part (second):
@Nocturnals, that's excellent, thank you. |
ForNeVeR
approved these changes
Apr 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt.. grin
Feel free to criticize & correct.
I'm not a fan of the if(.. is polywhatever) and then .. as polywhatever. constructs (casting twice)
Not sure how to fix it while maintaining readability.
I was also thinking about ditching the entire RenderGeometry thing. It creates more problems than it solves. For example I wanted to include colors in the svg but the geometry only provides path data not colors.
edit: I forgot: currently the geometry returned by BuildGeometry auto converts to cubic bezier curves while truetype fonts has quadratic curves. I've added the case for quadratic curves but it's untested. Should you want to use a more general portable non-wpf (freetype, for example) method of reading/rendering fonts, it's already in there and should work.