Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Upgrade graceful-fs dependency to the latest #9

Merged
merged 1 commit into from
Sep 6, 2015
Merged

deps: Upgrade graceful-fs dependency to the latest #9

merged 1 commit into from
Sep 6, 2015

Conversation

thefourtheye
Copy link
Collaborator

graceful-fs used to monkey-patch node's core fs module.
This has been fixed in the version 4.

Related: nodejs/node#2714

graceful-fs used to monkey-patch node's core fs module.
This has been fixed in the version 4.

Related: nodejs/node#2714
ForbesLindesay added a commit that referenced this pull request Sep 6, 2015
deps: Upgrade graceful-fs dependency to the latest
@ForbesLindesay ForbesLindesay merged commit 206a104 into ForbesLindesay:master Sep 6, 2015
@thefourtheye thefourtheye deleted the patch-1 branch September 6, 2015 17:23
@ForbesLindesay
Copy link
Owner

Would you like to be added as a collaborator on this project, to help review and merge pull requests?

@thefourtheye
Copy link
Collaborator Author

@ForbesLindesay That would be awesome.
I would love to do that. Thanks :-)

@ForbesLindesay
Copy link
Owner

Cool, you're added. Please follow these rules:

  1. never commit directly to master unless you're only editing documentation, or you're in the process of cutting a new release.
  2. never merge your own pull request unless it's had no comments from any collaborators for at least 24 hours.
  3. If you cut a new release, make sure you follow semver when updating the version number.

If you let me know your npm username I'll add you as an owner so you can release new versions :)

@thefourtheye
Copy link
Collaborator Author

@ForbesLindesay Thanks for the onboarding guidelines :-) My npm handle is thefourtheye.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants