feat: handle field names containing underscores on update record acti…

…ons (#735)
ForestAdmin · Jun 19, 2023 · d5d7661 · d5d7661
1 parent 56d4278
commit d5d7661
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/...ges/agent/src/services/model-customizations/actions/update-record/update-record-plugin.ts b/...ges/agent/src/services/model-customizations/actions/update-record/update-record-plugin.ts
@@ -1,4 +1,4 @@
-import { Plugin } from '@forestadmin/datasource-customizer';
+import { ActionContext, Plugin } from '@forestadmin/datasource-customizer';
 import {
   ModelCustomization,
   UpdateRecordActionConfiguration,
@@ -25,13 +25,17 @@ export default class UpdateRecordActionsPlugin {
 
       collection.addAction(action.name, {
         scope: action.configuration.scope,
-        execute: async context => {
+        execute: async (context: ActionContext) => {
           const {
             configuration: {
-              configuration: { fields },
+              configuration: { fields: fieldsToUpdate },
             },
           } = action;
 
+          const fields = fieldsToUpdate.reduce((acc, fieldToUpdate) => {
+            return { ...acc, [fieldToUpdate.fieldName]: fieldToUpdate.value };
+          }, {});
+
           await context.collection.update(context.filter, fields);
         },
       });

diff --git a/...ent/test/services/model-customizations/actions/update-record/update-record-plugin.test.ts b/...ent/test/services/model-customizations/actions/update-record/update-record-plugin.test.ts
@@ -24,7 +24,7 @@ describe('Services > ModelCustomizations > Actions > UpdateRecordActionsPlugin',
           configuration: {
             type: 'update-record',
             scope,
-            configuration: { fields: { field: 'value' } },
+            configuration: { fields: [{ fieldName: 'field', value: 'value' }] },
           },
         };
 
@@ -56,7 +56,7 @@ describe('Services > ModelCustomizations > Actions > UpdateRecordActionsPlugin',
         configuration: {
           type: 'update-record',
           scope: 'Global',
-          configuration: { fields: { field: 'value' } },
+          configuration: { fields: [{ fieldName: 'field', value: 'value' }] },
         },
       };
 

diff --git a/packages/forestadmin-client/src/model-customizations/types.ts b/packages/forestadmin-client/src/model-customizations/types.ts
@@ -41,7 +41,7 @@ export type WebhookActionConfiguration = ActionConfiguration<WebhookActionConfig
 };
 
 export type UpdateRecordActionConfigurationSpecific = {
-  fields: Record<string, unknown>;
+  fields: Array<{ fieldName: string; value: unknown }>;
 };
 
 export type UpdateRecordActionConfiguration =