Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add separator in action forms #1167

Merged
merged 8 commits into from
Sep 17, 2024
Merged

feat: add separator in action forms #1167

merged 8 commits into from
Sep 17, 2024

Conversation

EnkiP
Copy link
Member

@EnkiP EnkiP commented Sep 10, 2024

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@EnkiP EnkiP force-pushed the feat/add-separator-in-action-forms branch from 1f1a3f1 to b628f49 Compare September 12, 2024 08:42
@EnkiP EnkiP force-pushed the feat/add-separator-in-action-forms branch from 4638458 to 70a861f Compare September 12, 2024 15:00
@EnkiP EnkiP force-pushed the feat/add-separator-in-action-forms branch from 70a861f to e50894e Compare September 12, 2024 15:04
jbarreau
jbarreau reviewed Sep 17, 2024
View reviewed changes
packages/datasource-toolkit/src/interfaces/action.ts
@@ -250,6 +271,27 @@ export type ActionFieldWidget =
| 'FilePicker'
| 'JsonEditor';

type LayoutElementComponentType = 'Input' | 'Separator';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno if it's related to this line or another, but users can declare layout element of type 'Input', it's not relevant.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Sep 17, 2024

Code Climate has analyzed commit 3cb228e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.5%.

View more on Code Climate.

jbarreau
jbarreau approved these changes Sep 17, 2024
View reviewed changes
Copy link

@jbarreau jbarreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@EnkiP EnkiP merged commit 7d61527 into main Sep 17, 2024
22 checks passed
@EnkiP EnkiP deleted the feat/add-separator-in-action-forms branch September 17, 2024 13:18
forest-bot added a commit that referenced this pull request Sep 17, 2024
@forest-bot
chore(release): example@1.8.46 [skip ci]
b98f541 
## [1.8.46](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.8.45...example@1.8.46) (2024-09-17)

### Features

* add separator in action forms ([#1167](#1167)) ([7d61527](7d61527))
forest-bot added a commit that referenced this pull request Sep 17, 2024
@forest-bot
chore(release): @forestadmin/agent@1.42.0 [skip ci]
ed5aab6 
# [1.42.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.41.12...@forestadmin/agent@1.42.0) (2024-09-17)

### Features

* add separator in action forms ([#1167](#1167)) ([7d61527](7d61527))
forest-bot added a commit that referenced this pull request Sep 17, 2024
@forest-bot
chore(release): @forestadmin/datasource-customizer@1.48.0 [skip ci]
16601bc 
# [1.48.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.47.2...@forestadmin/datasource-customizer@1.48.0) (2024-09-17)

### Features

* add separator in action forms ([#1167](#1167)) ([7d61527](7d61527))
forest-bot added a commit that referenced this pull request Sep 17, 2024
@forest-bot
chore(release): @forestadmin/datasource-dummy@1.1.26 [skip ci]
d026af9 
## [1.1.26](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.1.25...@forestadmin/datasource-dummy@1.1.26) (2024-09-17)

### Features

* add separator in action forms ([#1167](#1167)) ([7d61527](7d61527))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.15 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Sep 17, 2024
@forest-bot
chore(release): @forestadmin/datasource-mongoose@1.7.15 [skip ci]
a40f629 
## [1.7.15](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.7.14...@forestadmin/datasource-mongoose@1.7.15) (2024-09-17)

### Bug Fixes

* **datasource-sql:** support for paranoid tables with snake case timestamp fields ([#1170](#1170)) ([96b54f9](96b54f9))

### Features

* add separator in action forms ([#1167](#1167)) ([7d61527](7d61527))

### Performance Improvements

* **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe))

### Reverts

*  "fix(datasource-sql): handle timestamps of tables with underscored column names" ([#1169](#1169)) ([3b76e38](3b76e38))
forest-bot added a commit that referenced this pull request Sep 17, 2024
@forest-bot
chore(release): @forestadmin/datasource-replica@1.3.32 [skip ci]
f3b37bb 
## [1.3.32](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-replica@1.3.31...@forestadmin/datasource-replica@1.3.32) (2024-09-17)

### Features

* add separator in action forms ([#1167](#1167)) ([7d61527](7d61527))
forest-bot added a commit that referenced this pull request Sep 17, 2024
@forest-bot
chore(release): @forestadmin/datasource-sequelize@1.9.3 [skip ci]
27775fc 
## [1.9.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sequelize@1.9.2...@forestadmin/datasource-sequelize@1.9.3) (2024-09-17)

### Bug Fixes

* **datasource-sql:** support for paranoid tables with snake case timestamp fields ([#1170](#1170)) ([96b54f9](96b54f9))

### Features

* add separator in action forms ([#1167](#1167)) ([7d61527](7d61527))

### Performance Improvements

* **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe))

### Reverts

*  "fix(datasource-sql): handle timestamps of tables with underscored column names" ([#1169](#1169)) ([3b76e38](3b76e38))
forest-bot added a commit that referenced this pull request Sep 17, 2024
@forest-bot
chore(release): @forestadmin/datasource-sql@1.14.19 [skip ci]
d0f819c 
## [1.14.19](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sql@1.14.18...@forestadmin/datasource-sql@1.14.19) (2024-09-17)

### Features

* add separator in action forms ([#1167](#1167)) ([7d61527](7d61527))

### Performance Improvements

* **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe))
forest-bot added a commit that referenced this pull request Sep 17, 2024
@forest-bot
chore(release): @forestadmin/datasource-toolkit@1.35.0 [skip ci]
c1069a3 
# [1.35.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.34.5...@forestadmin/datasource-toolkit@1.35.0) (2024-09-17)

### Bug Fixes

* **datasource-sql:** support for paranoid tables with snake case timestamp fields ([#1170](#1170)) ([96b54f9](96b54f9))

### Features

* add separator in action forms ([#1167](#1167)) ([7d61527](7d61527))

### Performance Improvements

* **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe))

### Reverts

*  "fix(datasource-sql): handle timestamps of tables with underscored column names" ([#1169](#1169)) ([3b76e38](3b76e38))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.8.46 🎉

The release is available on example@1.8.46

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Sep 17, 2024
@forest-bot
chore(release): @forestadmin/forest-cloud@1.11.10 [skip ci]
1562706 
## [1.11.10](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forest-cloud@1.11.9...@forestadmin/forest-cloud@1.11.10) (2024-09-17)

### Features

* add separator in action forms ([#1167](#1167)) ([7d61527](7d61527))
forest-bot added a commit that referenced this pull request Sep 17, 2024
@forest-bot
chore(release): @forestadmin/forestadmin-client@1.28.0 [skip ci]
ab5e4ca 
# [1.28.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.27.8...@forestadmin/forestadmin-client@1.28.0) (2024-09-17)

### Bug Fixes

* **datasource-sql:** support for paranoid tables with snake case timestamp fields ([#1170](#1170)) ([96b54f9](96b54f9))

### Features

* add separator in action forms ([#1167](#1167)) ([7d61527](7d61527))

### Performance Improvements

* **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe))

### Reverts

*  "fix(datasource-sql): handle timestamps of tables with underscored column names" ([#1169](#1169)) ([3b76e38](3b76e38))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.42.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Sep 17, 2024
@forest-bot
chore(release): @forestadmin/plugin-aws-s3@1.3.86 [skip ci]
543a09d 
## [1.3.86](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-aws-s3@1.3.85...@forestadmin/plugin-aws-s3@1.3.86) (2024-09-17)

### Features

* add separator in action forms ([#1167](#1167)) ([7d61527](7d61527))
forest-bot added a commit that referenced this pull request Sep 17, 2024
@forest-bot
chore(release): @forestadmin/plugin-export-advanced@1.0.97 [skip ci]
edef9ce 
## [1.0.97](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-export-advanced@1.0.96...@forestadmin/plugin-export-advanced@1.0.97) (2024-09-17)

### Features

* add separator in action forms ([#1167](#1167)) ([7d61527](7d61527))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.48.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Sep 17, 2024
@forest-bot
chore(release): @forestadmin/plugin-flattener@1.2.12 [skip ci]
85bde83 
## [1.2.12](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.2.11...@forestadmin/plugin-flattener@1.2.12) (2024-09-17)

### Features

* add separator in action forms ([#1167](#1167)) ([7d61527](7d61527))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.1.26 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realSpok realSpok realSpok left review comments

@jbarreau jbarreau jbarreau approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EnkiP @forest-bot @jbarreau @realSpok