perf(relation): improve has many relation by using not in when possible and available #1148

Thenkei · 2024-07-16T08:28:07Z

Definition of Done

General

Write an explicit title for the Pull Request, following Conventional Commits specification
Test manually the implemented changes
Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

Consider the security impact of the changes made

Thenkei · 2024-07-16T10:17:54Z

packages/datasource-customizer/src/decorators/relation/collection.ts

+      ) as ColumnSchema;
+
+      if (leafSchema.filterOperators.has('NotIn') && leaf.operator === 'NotEqual') {
+        // Possible optimization NotEqual


Technically is not just NotEqual but I wanted to prove it on NotEqual.

What I meant is that can also declare other optimisations with other NOT operators.

…e and available

codeclimate · 2024-09-13T09:56:34Z

Code Climate has analyzed commit cbaf269 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.5%.

View more on Code Climate.

DayTF

⚡

## [1.8.45](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.8.44...example@1.8.45) (2024-09-16) ### Performance Improvements * **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe))

forest-bot · 2024-09-16T16:12:13Z

🎉 This PR is included in version 1.11.9 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.41.12](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.41.11...@forestadmin/agent@1.41.12) (2024-09-16) ### Bug Fixes * **datasource-sql:** support for paranoid tables with snake case timestamp fields ([#1170](#1170)) ([96b54f9](96b54f9)) ### Performance Improvements * **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe)) ### Reverts * "fix(datasource-sql): handle timestamps of tables with underscored column names" ([#1169](#1169)) ([3b76e38](3b76e38))

## [1.47.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.47.1...@forestadmin/datasource-customizer@1.47.2) (2024-09-16) ### Bug Fixes * **datasource-sql:** support for paranoid tables with snake case timestamp fields ([#1170](#1170)) ([96b54f9](96b54f9)) ### Performance Improvements * **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe)) ### Reverts * "fix(datasource-sql): handle timestamps of tables with underscored column names" ([#1169](#1169)) ([3b76e38](3b76e38))

forest-bot · 2024-09-16T16:12:19Z

🎉 This PR is included in version 1.8.45 🎉

The release is available on example@1.8.45

Your semantic-release bot 📦🚀

## [1.1.25](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.1.24...@forestadmin/datasource-dummy@1.1.25) (2024-09-16) ### Bug Fixes * **datasource-sql:** support for paranoid tables with snake case timestamp fields ([#1170](#1170)) ([96b54f9](96b54f9)) ### Performance Improvements * **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe)) ### Reverts * "fix(datasource-sql): handle timestamps of tables with underscored column names" ([#1169](#1169)) ([3b76e38](3b76e38))

## [1.3.31](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-replica@1.3.30...@forestadmin/datasource-replica@1.3.31) (2024-09-16) ### Performance Improvements * **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe))

forest-bot · 2024-09-16T16:12:31Z

🎉 This PR is included in version 1.41.12 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.3.85](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-aws-s3@1.3.84...@forestadmin/plugin-aws-s3@1.3.85) (2024-09-16) ### Bug Fixes * **datasource-sql:** support for paranoid tables with snake case timestamp fields ([#1170](#1170)) ([96b54f9](96b54f9)) ### Performance Improvements * **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe)) ### Reverts * "fix(datasource-sql): handle timestamps of tables with underscored column names" ([#1169](#1169)) ([3b76e38](3b76e38))

## [1.0.96](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-export-advanced@1.0.95...@forestadmin/plugin-export-advanced@1.0.96) (2024-09-16) ### Bug Fixes * **datasource-sql:** support for paranoid tables with snake case timestamp fields ([#1170](#1170)) ([96b54f9](96b54f9)) ### Performance Improvements * **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe)) ### Reverts * "fix(datasource-sql): handle timestamps of tables with underscored column names" ([#1169](#1169)) ([3b76e38](3b76e38))

## [1.2.11](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.2.10...@forestadmin/plugin-flattener@1.2.11) (2024-09-16) ### Bug Fixes * **datasource-sql:** support for paranoid tables with snake case timestamp fields ([#1170](#1170)) ([96b54f9](96b54f9)) ### Performance Improvements * **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe)) ### Reverts * "fix(datasource-sql): handle timestamps of tables with underscored column names" ([#1169](#1169)) ([3b76e38](3b76e38))

forest-bot · 2024-09-16T16:12:49Z

🎉 This PR is included in version 1.47.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-09-16T16:13:01Z

🎉 This PR is included in version 1.1.25 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-09-16T16:13:10Z

🎉 This PR is included in version 1.3.31 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-09-16T16:13:13Z

🎉 This PR is included in version 1.3.85 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-09-16T16:13:22Z

🎉 This PR is included in version 1.0.96 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-09-16T16:13:31Z

🎉 This PR is included in version 1.2.11 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.7.15](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.7.14...@forestadmin/datasource-mongoose@1.7.15) (2024-09-17) ### Bug Fixes * **datasource-sql:** support for paranoid tables with snake case timestamp fields ([#1170](#1170)) ([96b54f9](96b54f9)) ### Features * add separator in action forms ([#1167](#1167)) ([7d61527](7d61527)) ### Performance Improvements * **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe)) ### Reverts * "fix(datasource-sql): handle timestamps of tables with underscored column names" ([#1169](#1169)) ([3b76e38](3b76e38))

forest-bot · 2024-09-17T13:30:43Z

🎉 This PR is included in version 1.3.15 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.9.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sequelize@1.9.2...@forestadmin/datasource-sequelize@1.9.3) (2024-09-17) ### Bug Fixes * **datasource-sql:** support for paranoid tables with snake case timestamp fields ([#1170](#1170)) ([96b54f9](96b54f9)) ### Features * add separator in action forms ([#1167](#1167)) ([7d61527](7d61527)) ### Performance Improvements * **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe)) ### Reverts * "fix(datasource-sql): handle timestamps of tables with underscored column names" ([#1169](#1169)) ([3b76e38](3b76e38))

## [1.14.19](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sql@1.14.18...@forestadmin/datasource-sql@1.14.19) (2024-09-17) ### Features * add separator in action forms ([#1167](#1167)) ([7d61527](7d61527)) ### Performance Improvements * **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe))

# [1.35.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.34.5...@forestadmin/datasource-toolkit@1.35.0) (2024-09-17) ### Bug Fixes * **datasource-sql:** support for paranoid tables with snake case timestamp fields ([#1170](#1170)) ([96b54f9](96b54f9)) ### Features * add separator in action forms ([#1167](#1167)) ([7d61527](7d61527)) ### Performance Improvements * **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe)) ### Reverts * "fix(datasource-sql): handle timestamps of tables with underscored column names" ([#1169](#1169)) ([3b76e38](3b76e38))

# [1.28.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.27.8...@forestadmin/forestadmin-client@1.28.0) (2024-09-17) ### Bug Fixes * **datasource-sql:** support for paranoid tables with snake case timestamp fields ([#1170](#1170)) ([96b54f9](96b54f9)) ### Features * add separator in action forms ([#1167](#1167)) ([7d61527](7d61527)) ### Performance Improvements * **relation:** improve has many relation by using not in when possible and available ([#1148](#1148)) ([a15eefe](a15eefe)) ### Reverts * "fix(datasource-sql): handle timestamps of tables with underscored column names" ([#1169](#1169)) ([3b76e38](3b76e38))

Thenkei commented Jul 16, 2024

View reviewed changes

Thenkei added 3 commits September 13, 2024 10:55

perf(relation): improve hasmany relation by using not in when possibl…

cd07999

…e and available

refactor: early returns please

1f149b6

test: add missing tests cases

1b57c2c

Thenkei force-pushed the perf/relation-not-in-optimization branch from 7860e81 to 1b57c2c Compare September 13, 2024 09:35

Thenkei marked this pull request as ready for review September 13, 2024 09:35

fix: remove console logs typos

cbaf269

DayTF approved these changes Sep 16, 2024

View reviewed changes

Thenkei merged commit a15eefe into main Sep 16, 2024
22 checks passed

Thenkei deleted the perf/relation-not-in-optimization branch September 16, 2024 15:59

forest-bot added the released label Sep 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(relation): improve has many relation by using not in when possible and available #1148

perf(relation): improve has many relation by using not in when possible and available #1148

Thenkei commented Jul 16, 2024

Thenkei Jul 16, 2024

Thenkei Sep 13, 2024

codeclimate bot commented Sep 13, 2024

DayTF left a comment •

edited

Loading

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 17, 2024

perf(relation): improve has many relation by using not in when possible and available #1148

perf(relation): improve has many relation by using not in when possible and available #1148

Conversation

Thenkei commented Jul 16, 2024

Definition of Done

General

Security

Thenkei Jul 16, 2024

Choose a reason for hiding this comment

Thenkei Sep 13, 2024

Choose a reason for hiding this comment

codeclimate bot commented Sep 13, 2024

DayTF left a comment • edited Loading

Choose a reason for hiding this comment

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 16, 2024

forest-bot commented Sep 17, 2024

DayTF left a comment •

edited

Loading