fix(logger): logger should display the right status code in case of error #1194

Thenkei · 2024-10-15T12:29:49Z

…

Definition of Done

General

Write an explicit title for the Pull Request, following Conventional Commits specification
Test manually the implemented changes
Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

Consider the security impact of the changes made

…rror

Thenkei · 2024-10-15T12:32:41Z

packages/agent/src/types.ts

@@ -47,8 +47,8 @@ export enum HttpCode {

 export enum RouteType {
  // Changing the values of this enum changes the order in which routes are loaded into koa-router.
-  ErrorHandler = 0,
-  LoggerHandler = 1,
+  LoggerHandler = 0,


The previous order prevent to have the proper status since it's handled by the ErrorHandler.

Thenkei · 2024-10-15T12:53:06Z

codeclimate · 2024-10-15T12:56:49Z

Code Climate has analyzed commit 5b996d2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.5% (0.0% change).

View more on Code Climate.

## [1.11.6](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.11.5...example@1.11.6) (2024-10-15) ### Bug Fixes * **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764)) * **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669))

## [1.50.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.50.2...@forestadmin/agent@1.50.3) (2024-10-15) ### Bug Fixes * **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764)) * **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669))

forest-bot · 2024-10-15T15:42:34Z

🎉 This PR is included in version 1.11.26 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-15T15:42:43Z

🎉 This PR is included in version 1.11.6 🎉

The release is available on example@1.11.6

Your semantic-release bot 📦🚀

forest-bot · 2024-10-15T15:42:49Z

🎉 This PR is included in version 1.50.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-18T11:52:51Z

🎉 This PR is included in version 1.1.8 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.55.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.55.1...@forestadmin/datasource-customizer@1.55.2) (2024-10-18) ### Bug Fixes * fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9)) * **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764)) * **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669)) ### Features * add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))

## [1.1.37](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.1.36...@forestadmin/datasource-dummy@1.1.37) (2024-10-18) ### Bug Fixes * fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9)) * **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764)) * **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669)) ### Features * add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))

## [1.3.25](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongo@1.3.24...@forestadmin/datasource-mongo@1.3.25) (2024-10-18) ### Bug Fixes * fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9)) * **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764)) * **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669)) ### Features * add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))

## [1.8.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.8.4...@forestadmin/datasource-mongoose@1.8.5) (2024-10-18) ### Bug Fixes * fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9)) * **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764)) * **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669)) ### Features * add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))

# [1.5.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-replica@1.4.5...@forestadmin/datasource-replica@1.5.0) (2024-10-18) ### Bug Fixes * fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9)) * **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764)) * **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669)) ### Features * add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))

## [1.10.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sequelize@1.10.4...@forestadmin/datasource-sequelize@1.10.5) (2024-10-18) ### Bug Fixes * fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9)) * **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764)) * **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669)) ### Features * add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))

## [1.14.31](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sql@1.14.30...@forestadmin/datasource-sql@1.14.31) (2024-10-18) ### Bug Fixes * fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9)) * **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764)) * **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669)) ### Features * add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))

# [1.43.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.42.1...@forestadmin/datasource-toolkit@1.43.0) (2024-10-18) ### Bug Fixes * fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9)) * **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764)) * **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669)) ### Features * add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))

## [1.34.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.34.1...@forestadmin/forestadmin-client@1.34.2) (2024-10-18) ### Bug Fixes * fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9)) * **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764)) * **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669)) ### Features * add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))

## [1.4.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-aws-s3@1.4.4...@forestadmin/plugin-aws-s3@1.4.5) (2024-10-18) ### Bug Fixes * fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9)) * **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764)) * **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669)) ### Features * add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))

## [1.3.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.3.4...@forestadmin/plugin-flattener@1.3.5) (2024-10-18) ### Bug Fixes * fix excel export type ([#1195](#1195)) ([ac7f7d9](ac7f7d9)) * **logger:** logger should display the right status code in case of error ([#1194](#1194)) ([d328764](d328764)) * **security:** patch cookie dependency vulnerabilities ([#1193](#1193)) ([1fd3669](1fd3669)) ### Features * add caller ip in action context.caller.request.ip ([#1196](#1196)) ([25aa5b8](25aa5b8))

forest-bot · 2024-10-18T12:25:03Z

🎉 This PR is included in version 1.55.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-18T12:25:21Z

🎉 This PR is included in version 1.1.37 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-18T12:25:41Z

🎉 This PR is included in version 1.3.25 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-18T12:25:57Z

🎉 This PR is included in version 1.8.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-18T12:26:12Z

🎉 This PR is included in version 1.5.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-18T12:26:23Z

🎉 This PR is included in version 1.10.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-18T12:26:36Z

🎉 This PR is included in version 1.14.31 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-18T12:26:44Z

🎉 This PR is included in version 1.43.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-18T12:26:57Z

🎉 This PR is included in version 1.34.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-18T12:27:12Z

🎉 This PR is included in version 1.4.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-18T12:27:24Z

🎉 This PR is included in version 1.3.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

fix(logger): logger should display the right status code in case of e…

af73c71

…rror

Thenkei commented Oct 15, 2024

View reviewed changes

fix(logger): test

5b996d2

DayTF approved these changes Oct 15, 2024

View reviewed changes

Thenkei merged commit d328764 into main Oct 15, 2024
22 checks passed

Thenkei deleted the fix/logger-status-code branch October 15, 2024 15:33

forest-bot added the released label Oct 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(logger): logger should display the right status code in case of error #1194

fix(logger): logger should display the right status code in case of error #1194

Thenkei commented Oct 15, 2024

Thenkei Oct 15, 2024

Thenkei commented Oct 15, 2024

codeclimate bot commented Oct 15, 2024

forest-bot commented Oct 15, 2024

forest-bot commented Oct 15, 2024

forest-bot commented Oct 15, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

fix(logger): logger should display the right status code in case of error #1194

fix(logger): logger should display the right status code in case of error #1194

Conversation

Thenkei commented Oct 15, 2024

Definition of Done

General

Security

Thenkei Oct 15, 2024

Choose a reason for hiding this comment

Thenkei commented Oct 15, 2024

codeclimate bot commented Oct 15, 2024

forest-bot commented Oct 15, 2024

forest-bot commented Oct 15, 2024

forest-bot commented Oct 15, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024

forest-bot commented Oct 18, 2024