chore(capabilities): define native query connection capabilities #1211
Conversation
DayTF
force-pushed
the
feat/capabilities/live-query
branch
from
a11335c to
4c85e0a
Compare
|
Code Climate has analyzed commit 54eb825 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (98% is the threshold). This pull request will bring the total coverage in the repository to 97.2% (0.0% change). View more on Code Climate. |
|
How is the dev supposed to declare that his datasource supports native queries in this PR ? 🙏 |
| @@ -62,4 +75,18 @@ export default class CompositeDatasource<T extends Collection = Collection> | |||
|
|
|||
| throw new Error(`Chart '${name}' is not defined in the dataSource.`); | |||
| } | |||
|
|
|||
| async executeNativeQuery( | |||
There was a problem hiding this comment.
Is there a way to test this at the moment ?
There was a problem hiding this comment.
The composite datasource implementation is already tested, only the real execution is not yet done as it is bound to change, I simply made the closest implementation I had in mind for it
| return this.dataSources | ||
| .find(datasource => Boolean(datasource.nativeQueryConnections[connectionName])) | ||
| .executeNativeQuery(connectionName, query, contextVariables); | ||
| } |
There was a problem hiding this comment.
why not this ?
| return this.dataSources | |
| .find(datasource => Boolean(datasource.nativeQueryConnections[connectionName])) | |
| .executeNativeQuery(connectionName, query, contextVariables); | |
| } | |
| return this.nativeQueryConnections[connectionName] | |
| .executeNativeQuery(connectionName, query, contextVariables); | |
| } |
There was a problem hiding this comment.
the datasource has the implementation of the executeNativeQuery
There was a problem hiding this comment.
-
✅ PR title
-
✅ Destination branch
-
✅ PR linked to the clickup task
-
ℹ️ Code review -> small question
- ✅ Use pure functions when possible
- ✅ Performance concerns
- ✅ Security concerns
- ✅ The PR tackle one subject only
-
✅ Automatic tests
- ✅ Unit tests
- ⤬ Integration tests
-
✅ Manual tests
- ℹ️ Test the functionality. Did not the query execution
- ⤬ Test error cases
DayTF
changed the title
|
🎉 This PR is included in version 1.12.6 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.11.14 🎉 The release is available on Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.53.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.55.5 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.1.40 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.4 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.4.8 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.1.13 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.3.8 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.3.26 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Definition of Done
General
Security