Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not override view default sorting ordrer #1245

Merged
merged 5 commits into from
Jan 24, 2025
Merged

fix: do not override view default sorting ordrer #1245

merged 5 commits into from
Jan 24, 2025

Conversation

realSpok
Copy link
Contributor

@realSpok realSpok commented Jan 24, 2025 •
edited
Loading

Definition of Done

#86c1rzr91

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@codeclimate CodeClimate
Copy link

codeclimate bot commented Jan 24, 2025

Code Climate has analyzed commit 75d92f4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.2%.

View more on Code Climate.

@forest-bot
Copy link
Member

Task linked: CU-86c1rzr91 🔥 P3 - Agent - Default database ordering is not respected

arnaud-moncel
arnaud-moncel approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@arnaud-moncel arnaud-moncel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested work fine with simple postgres table (no bug, and no sorting on the sql query) 🚀

@realSpok realSpok merged commit 8e27769 into main Jan 24, 2025
22 checks passed
@realSpok realSpok deleted the fix/do-not-override-view-default-sorting-ordrer branch January 24, 2025 14:28
forest-bot added a commit that referenced this pull request Jan 24, 2025
@forest-bot
chore(release): example@1.13.3 [skip ci]
14f2ee5 
## [1.13.3](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.13.2...example@1.13.3) (2025-01-24)

### Bug Fixes

* do not override view default sorting ordrer ([#1245](#1245)) ([8e27769](8e27769))
* **lazy join:** do not remove foreignkey when they are asking ([#1246](#1246)) ([621b243](621b243))
forest-bot added a commit that referenced this pull request Jan 24, 2025
@forest-bot
chore(release): @forestadmin/agent@1.58.2 [skip ci]
0d6bed9 
## [1.58.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.58.1...@forestadmin/agent@1.58.2) (2025-01-24)

### Bug Fixes

* do not override view default sorting ordrer ([#1245](#1245)) ([8e27769](8e27769))
* **lazy join:** do not remove foreignkey when they are asking ([#1246](#1246)) ([621b243](621b243))
forest-bot added a commit that referenced this pull request Jan 24, 2025
@forest-bot
chore(release): @forestadmin/datasource-customizer@1.61.1 [skip ci]
c480a2f 
## [1.61.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.61.0...@forestadmin/datasource-customizer@1.61.1) (2025-01-24)

### Bug Fixes

* do not override view default sorting ordrer ([#1245](#1245)) ([8e27769](8e27769))
* **lazy join:** do not remove foreignkey when they are asking ([#1246](#1246)) ([621b243](621b243))
forest-bot added a commit that referenced this pull request Jan 24, 2025
@forest-bot
chore(release): @forestadmin/datasource-dummy@1.1.48 [skip ci]
29591e0 
## [1.1.48](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.1.47...@forestadmin/datasource-dummy@1.1.48) (2025-01-24)

### Bug Fixes

* do not override view default sorting ordrer ([#1245](#1245)) ([8e27769](8e27769))
* **lazy join:** do not remove foreignkey when they are asking ([#1246](#1246)) ([621b243](621b243))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.5.13 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Jan 24, 2025
@forest-bot
chore(release): @forestadmin/forest-cloud@1.12.21 [skip ci]
e384209 
## [1.12.21](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forest-cloud@1.12.20...@forestadmin/forest-cloud@1.12.21) (2025-01-24)

### Bug Fixes

* do not override view default sorting ordrer ([#1245](#1245)) ([8e27769](8e27769))
* **lazy join:** do not remove foreignkey when they are asking ([#1246](#1246)) ([621b243](621b243))
forest-bot added a commit that referenced this pull request Jan 24, 2025
@forest-bot
chore(release): @forestadmin/plugin-aws-s3@1.4.16 [skip ci]
7f7a65b 
## [1.4.16](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-aws-s3@1.4.15...@forestadmin/plugin-aws-s3@1.4.16) (2025-01-24)

### Bug Fixes

* do not override view default sorting ordrer ([#1245](#1245)) ([8e27769](8e27769))
* **lazy join:** do not remove foreignkey when they are asking ([#1246](#1246)) ([621b243](621b243))
forest-bot added a commit that referenced this pull request Jan 24, 2025
@forest-bot
chore(release): @forestadmin/plugin-export-advanced@1.1.22 [skip ci]
9e70a48 
## [1.1.22](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-export-advanced@1.1.21...@forestadmin/plugin-export-advanced@1.1.22) (2025-01-24)

### Bug Fixes

* do not override view default sorting ordrer ([#1245](#1245)) ([8e27769](8e27769))
* **lazy join:** do not remove foreignkey when they are asking ([#1246](#1246)) ([621b243](621b243))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.13.3 🎉

The release is available on example@1.13.3

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Jan 24, 2025
@forest-bot
chore(release): @forestadmin/plugin-flattener@1.4.6 [skip ci]
2843dce 
## [1.4.6](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.4.5...@forestadmin/plugin-flattener@1.4.6) (2025-01-24)

### Bug Fixes

* do not override view default sorting ordrer ([#1245](#1245)) ([8e27769](8e27769))
* **lazy join:** do not remove foreignkey when they are asking ([#1246](#1246)) ([621b243](621b243))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.58.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.61.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.1.48 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.12.21 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.4.16 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.1.22 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.4.6 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-moncel arnaud-moncel arnaud-moncel approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realSpok @forest-bot @arnaud-moncel