Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip mssql tables with dots in their names instead of crashing the agent #869

Closed
wants to merge 2 commits into from
Closed

fix: skip mssql tables with dots in their names instead of crashing the agent #869

wants to merge 2 commits into from

Conversation

realSpok
Copy link
Contributor

@realSpok realSpok commented Nov 7, 2023

#860ryxma4

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@forest-bot
Copy link
Member

Task linked: CU-860ryxma4 🔥🔥🔥 P1 - MSSQL cloud onboarding error - No description found for table

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 7, 2023

Code Climate has analyzed commit dbc19d1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 99.0%.

View more on Code Climate.

@realSpok
Copy link
Contributor Author

realSpok commented Nov 8, 2023

Closed in favor of #870

@realSpok realSpok closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realSpok @forest-bot