Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(action result builder): allow user to set SA response headers #945

Merged
merged 6 commits into from
Feb 2, 2024
Merged

feat(action result builder): allow user to set SA response headers #945

merged 6 commits into from
Feb 2, 2024

Conversation

arnaud-moncel
Copy link
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

Thenkei
Thenkei reviewed Jan 31, 2024
View reviewed changes
packages/agent/src/routes/modification/action/action.ts
@@ -105,6 +105,10 @@ export default class ActionRoute extends CollectionRoute {
const data = ForestValueConverter.makeFormData(dataSource, rawData, fields);
const result = await this.collection.execute(caller, this.actionName, data, filterForCaller);

if (result.responseHeaders) {
context.response.set(result.responseHeaders);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@codeclimate CodeClimate
Copy link

codeclimate bot commented Jan 31, 2024

Code Climate has analyzed commit 9b8b3f6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.3%.

View more on Code Climate.

@arnaud-moncel arnaud-moncel merged commit ce37c01 into main Feb 2, 2024
20 checks passed
@arnaud-moncel arnaud-moncel deleted the feat/sa-response-header branch February 2, 2024 08:43
forest-bot added a commit that referenced this pull request Feb 2, 2024
@forest-bot
chore(release): example@1.6.81 [skip ci]
38c4eae 
## [1.6.81](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.6.80...example@1.6.81) (2024-02-02)

### Features

* **action result builder:** allow user to set SA response headers ([#945](#945)) ([ce37c01](ce37c01))
forest-bot added a commit that referenced this pull request Feb 2, 2024
@forest-bot
chore(release): @forestadmin/agent@1.37.0 [skip ci]
6f6d7b7 
# [1.37.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.36.20...@forestadmin/agent@1.37.0) (2024-02-02)

### Features

* **action result builder:** allow user to set SA response headers ([#945](#945)) ([ce37c01](ce37c01))
forest-bot added a commit that referenced this pull request Feb 2, 2024
@forest-bot
chore(release): @forestadmin/datasource-customizer@1.42.0 [skip ci]
60a5af6 
# [1.42.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.41.1...@forestadmin/datasource-customizer@1.42.0) (2024-02-02)

### Bug Fixes

* **schema:** force schema metadata update even in production ([#947](#947)) ([3ce68e0](3ce68e0))

### Features

* **action result builder:** allow user to set SA response headers ([#945](#945)) ([ce37c01](ce37c01))
forest-bot added a commit that referenced this pull request Feb 2, 2024
@forest-bot
chore(release): @forestadmin/datasource-dummy@1.1.2 [skip ci]
ad5464a 
## [1.1.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.1.1...@forestadmin/datasource-dummy@1.1.2) (2024-02-02)

### Bug Fixes

* **schema:** force schema metadata update even in production ([#947](#947)) ([3ce68e0](3ce68e0))

### Features

* **action result builder:** allow user to set SA response headers ([#945](#945)) ([ce37c01](ce37c01))
forest-bot added a commit that referenced this pull request Feb 2, 2024
@forest-bot
chore(release): @forestadmin/datasource-mongoose@1.6.2 [skip ci]
0da5728 
## [1.6.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.6.1...@forestadmin/datasource-mongoose@1.6.2) (2024-02-02)

### Bug Fixes

* **schema:** force schema metadata update even in production ([#947](#947)) ([3ce68e0](3ce68e0))

### Features

* **action result builder:** allow user to set SA response headers ([#945](#945)) ([ce37c01](ce37c01))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.73 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Feb 2, 2024
@forest-bot
chore(release): @forestadmin/datasource-replica@1.0.62 [skip ci]
71575e9 
## [1.0.62](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-replica@1.0.61...@forestadmin/datasource-replica@1.0.62) (2024-02-02)

### Bug Fixes

* **schema:** force schema metadata update even in production ([#947](#947)) ([3ce68e0](3ce68e0))

### Features

* **action result builder:** allow user to set SA response headers ([#945](#945)) ([ce37c01](ce37c01))
forest-bot added a commit that referenced this pull request Feb 2, 2024
@forest-bot
chore(release): @forestadmin/datasource-sequelize@1.6.2 [skip ci]
2891479 
## [1.6.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sequelize@1.6.1...@forestadmin/datasource-sequelize@1.6.2) (2024-02-02)

### Bug Fixes

* **schema:** force schema metadata update even in production ([#947](#947)) ([3ce68e0](3ce68e0))

### Features

* **action result builder:** allow user to set SA response headers ([#945](#945)) ([ce37c01](ce37c01))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.6.81 🎉

The release is available on example@1.6.81

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Feb 2, 2024
@forest-bot
chore(release): @forestadmin/datasource-sql@1.7.47 [skip ci]
0d8eff5 
## [1.7.47](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sql@1.7.46...@forestadmin/datasource-sql@1.7.47) (2024-02-02)

### Bug Fixes

* **schema:** force schema metadata update even in production ([#947](#947)) ([3ce68e0](3ce68e0))

### Features

* **action result builder:** allow user to set SA response headers ([#945](#945)) ([ce37c01](ce37c01))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.37.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Feb 2, 2024
@forest-bot
chore(release): @forestadmin/datasource-toolkit@1.31.0 [skip ci]
152c7a0 
# [1.31.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.30.1...@forestadmin/datasource-toolkit@1.31.0) (2024-02-02)

### Bug Fixes

* **schema:** force schema metadata update even in production ([#947](#947)) ([3ce68e0](3ce68e0))

### Features

* **action result builder:** allow user to set SA response headers ([#945](#945)) ([ce37c01](ce37c01))
forest-bot added a commit that referenced this pull request Feb 2, 2024
@forest-bot
chore(release): @forestadmin/forestadmin-client@1.25.8 [skip ci]
3a626e3 
## [1.25.8](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.25.7...@forestadmin/forestadmin-client@1.25.8) (2024-02-02)

### Bug Fixes

* **schema:** force schema metadata update even in production ([#947](#947)) ([3ce68e0](3ce68e0))

### Features

* **action result builder:** allow user to set SA response headers ([#945](#945)) ([ce37c01](ce37c01))
forest-bot added a commit that referenced this pull request Feb 2, 2024
@forest-bot
chore(release): @forestadmin/plugin-aws-s3@1.3.61 [skip ci]
9a54778 
## [1.3.61](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-aws-s3@1.3.60...@forestadmin/plugin-aws-s3@1.3.61) (2024-02-02)

### Bug Fixes

* **schema:** force schema metadata update even in production ([#947](#947)) ([3ce68e0](3ce68e0))

### Features

* **action result builder:** allow user to set SA response headers ([#945](#945)) ([ce37c01](ce37c01))
forest-bot added a commit that referenced this pull request Feb 2, 2024
@forest-bot
chore(release): @forestadmin/plugin-flattener@1.0.86 [skip ci]
c33100d 
## [1.0.86](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.0.85...@forestadmin/plugin-flattener@1.0.86) (2024-02-02)

### Bug Fixes

* **schema:** force schema metadata update even in production ([#947](#947)) ([3ce68e0](3ce68e0))

### Features

* **action result builder:** allow user to set SA response headers ([#945](#945)) ([ce37c01](ce37c01))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.42.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.1.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.6.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.62 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.6.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.7.47 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.31.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.25.8 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.61 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.0.86 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thenkei Thenkei Thenkei left review comments

@SteveBunlon SteveBunlon SteveBunlon approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arnaud-moncel @forest-bot @Thenkei @SteveBunlon