Allow github token to not be set when getting releases (#5)

Signed-off-by: Sophie Wigmore <swigmore@vmware.com>

Co-authored-by: Josh Zarrabi <jzarrabi@vmware.com>

github/release_service.go

@@ -40,7 +40,10 @@ func (rs ReleaseService) Get(org, repo string) (Release, error) {
 	if err != nil {
 		return Release{}, err
 	}
-	req.Header.Set("Authorization", fmt.Sprintf("token %s", rs.config.Token))
+
+	if rs.config.Token != "" {
+		req.Header.Set("Authorization", fmt.Sprintf("token %s", rs.config.Token))
+	}
 
 	resp, err := http.DefaultClient.Do(req)
 	if err != nil {
@@ -65,7 +68,11 @@ func (rs ReleaseService) GetReleaseAsset(asset ReleaseAsset) (io.ReadCloser, err
 	if err != nil {
 		return nil, err
 	}
-	req.Header.Set("Authorization", fmt.Sprintf("token %s", rs.config.Token))
+
+	if rs.config.Token != "" {
+		req.Header.Set("Authorization", fmt.Sprintf("token %s", rs.config.Token))
+	}
+
 	req.Header.Add("Accept", "application/octet-stream")
 
 	resp, err := http.DefaultClient.Do(req)
@@ -85,7 +92,10 @@ func (rs ReleaseService) GetReleaseTarball(url string) (io.ReadCloser, error) {
 	if err != nil {
 		return nil, err
 	}
-	req.Header.Set("Authorization", fmt.Sprintf("token %s", rs.config.Token))
+
+	if rs.config.Token != "" {
+		req.Header.Set("Authorization", fmt.Sprintf("token %s", rs.config.Token))
+	}
 
 	resp, err := http.DefaultClient.Do(req)
 	if err != nil {

github/release_service_test.go

@@ -70,6 +70,52 @@ func testReleaseService(t *testing.T, context spec.G, it spec.S) {
 			}))
 		})
 
+		context("when no github token is specified", func() {
+			var authToken string
+			it.Before(func() {
+
+				api = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
+					dump, _ := httputil.DumpRequest(req, true)
+
+					authToken = req.Header.Get("Authorization")
+
+					switch req.URL.Path {
+					case "/repos/some-org/some-repo/releases/latest":
+						w.Write([]byte(`{
+  "tag_name": "some-tag",
+  "assets": [
+    {
+      "url": "some-url"
+    }
+  ],
+  "tarball_url": "some-tarball-url"
+					}`))
+					default:
+						Fail(fmt.Sprintf("unexpected request:\n%s", dump))
+					}
+
+				}))
+				service = github.NewReleaseService(github.Config{
+					Endpoint: api.URL,
+				})
+
+			})
+			it("makes the call without any authorization header", func() {
+				release, err := service.Get("some-org", "some-repo")
+				Expect(err).ToNot(HaveOccurred())
+				Expect(release).To(Equal(github.Release{
+					TagName: "some-tag",
+					Assets: []github.ReleaseAsset{
+						{
+							URL: "some-url",
+						},
+					},
+					TarballURL: "some-tarball-url",
+				}))
+				Expect(authToken).To(Equal(""))
+			})
+		})
+
 		context("failure cases", func() {
 			context("when the request url is malformed", func() {
 				it.Before(func() {
@@ -139,6 +185,44 @@ func testReleaseService(t *testing.T, context spec.G, it spec.S) {
 			Expect(response.Close()).To(Succeed())
 		})
 
+		context("when no github token is specified", func() {
+			var authToken string
+			it.Before(func() {
+
+				api = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
+					dump, _ := httputil.DumpRequest(req, true)
+
+					authToken = req.Header.Get("Authorization")
+
+					switch req.URL.Path {
+					case "/some-url":
+						w.Write([]byte(`some-asset`))
+					default:
+						Fail(fmt.Sprintf("unexpected request:\n%s", dump))
+					}
+
+				}))
+
+				service = github.NewReleaseService(github.Config{
+					Endpoint: api.URL,
+				})
+
+			})
+			it("fetches the latest release without any authorization header", func() {
+				response, err := service.GetReleaseAsset(github.ReleaseAsset{
+					URL: fmt.Sprintf("%s/some-url", api.URL),
+				})
+				Expect(err).ToNot(HaveOccurred())
+
+				content, err := ioutil.ReadAll(response)
+				Expect(err).ToNot(HaveOccurred())
+				Expect(string(content)).To(Equal("some-asset"))
+
+				Expect(response.Close()).To(Succeed())
+				Expect(authToken).To(Equal(""))
+			})
+		})
+
 		context("failure cases", func() {
 			context("when the url is malformed", func() {
 				it("returns an error", func() {
@@ -210,6 +294,42 @@ func testReleaseService(t *testing.T, context spec.G, it spec.S) {
 			Expect(response.Close()).To(Succeed())
 		})
 
+		context("when no github token is specified", func() {
+			var authToken string
+			it.Before(func() {
+
+				api = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
+					dump, _ := httputil.DumpRequest(req, true)
+
+					authToken = req.Header.Get("Authorization")
+
+					switch req.URL.Path {
+					case "/some-tarball-url":
+						w.Write([]byte(`some-tarball`))
+					default:
+						Fail(fmt.Sprintf("unexpected request:\n%s", dump))
+					}
+
+				}))
+
+				service = github.NewReleaseService(github.Config{
+					Endpoint: api.URL,
+				})
+
+			})
+			it("fetches the latest release tarball without any authorization header", func() {
+				response, err := service.GetReleaseTarball(fmt.Sprintf("%s/some-tarball-url", api.URL))
+				Expect(err).ToNot(HaveOccurred())
+
+				content, err := ioutil.ReadAll(response)
+				Expect(err).ToNot(HaveOccurred())
+				Expect(string(content)).To(Equal("some-tarball"))
+
+				Expect(response.Close()).To(Succeed())
+				Expect(authToken).To(Equal(""))
+			})
+		})
+
 		context("failure cases", func() {
 			context("when the url is malformed", func() {
 				it("returns an error", func() {

init_test.go

@@ -1,7 +1,6 @@
 package freezer_test
 
 import (
-	"os"
 	"testing"
 
 	"github.com/sclevine/spec"
@@ -11,12 +10,6 @@ import (
 var gitToken string
 
 func TestFreezer(t *testing.T) {
-	var ok bool
-	gitToken, ok = os.LookupEnv("GIT_TOKEN")
-	if !ok {
-		t.Fatal("$GIT_TOKEN environment variable must be set")
-	}
-
 	suite := spec.New("freezer", spec.Report(report.Terminal{}))
 	suite("CacheManager", testCacheManager)
 	suite("FileSystem", testFileSystem)