fix: remove logo from credential details card (#97)

* fix: remove logo from credential details card * fix: remove info useless class
ForkbombEu · Jun 12, 2024 · 1bebbbd · 1bebbbd
1 parent 81af665
commit 1bebbbd
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 23 deletions.
diff --git a/src/components.d.ts b/src/components.d.ts
@@ -38,7 +38,6 @@ export namespace Components {
     interface DCredentialDetail {
         "description": string;
         "issuer": string;
-        "logoSrc"?: string;
         "longDescription"?: string;
         "name": string;
     }
@@ -305,7 +304,6 @@ declare namespace LocalJSX {
     interface DCredentialDetail {
         "description"?: string;
         "issuer"?: string;
-        "logoSrc"?: string;
         "longDescription"?: string;
         "name"?: string;
     }

diff --git a/src/components/avatar/readme.md b/src/components/avatar/readme.md
@@ -20,14 +20,12 @@
 ### Used by
 
  - [d-credential-card](../credential-card)
- - [d-credential-detail](../credential-detail)
  - [d-credential-service](../credential-service)
 
 ### Graph
 ```mermaid
 graph TD;
   d-credential-card --> d-avatar
-  d-credential-detail --> d-avatar
   d-credential-service --> d-avatar
   style d-avatar fill:#f9f,stroke:#333,stroke-width:4px
 ```

diff --git a/src/components/credential-detail/d-credential-detail.css b/src/components/credential-detail/d-credential-detail.css
@@ -14,9 +14,9 @@
   @apply flex text-on text-xl not-italic font-semibold items-center gap-2;
 }
 
-.info {
+/* .info {
   @apply flex flex-col items-start gap-2;
-}
+} */
 
 .short-description {
   @apply text-on text-base not-italic font-medium leading-[20.5px] tracking-[-0.5px];

diff --git a/src/components/credential-detail/d-credential-detail.tsx b/src/components/credential-detail/d-credential-detail.tsx
@@ -10,7 +10,6 @@ export class DCredentialDetail {
   @Prop({ reflect: true }) description: string;
   @Prop({ reflect: true }) issuer: string;
   @Prop({ reflect: true }) longDescription?: string;
-  @Prop({ reflect: true }) logoSrc?: string;
 
 
   render() {
@@ -19,7 +18,6 @@ export class DCredentialDetail {
       <Host>
         <div class="frame">
           <div class="heading">
-            <d-avatar name={this.name} src={this.logoSrc}></d-avatar>
             <span class="name">{this.name}</span>
           </div>
           <div class="info">

diff --git a/src/components/credential-detail/readme.md b/src/components/credential-detail/readme.md
@@ -11,24 +11,10 @@
 | ----------------- | ------------------ | ----------- | -------- | ----------- |
 | `description`     | `description`      |             | `string` | `undefined` |
 | `issuer`          | `issuer`           |             | `string` | `undefined` |
-| `logoSrc`         | `logo-src`         |             | `string` | `undefined` |
 | `longDescription` | `long-description` |             | `string` | `undefined` |
 | `name`            | `name`             |             | `string` | `undefined` |
 
 
-## Dependencies
-
-### Depends on
-
-- [d-avatar](../avatar)
-
-### Graph
-```mermaid
-graph TD;
-  d-credential-detail --> d-avatar
-  style d-credential-detail fill:#f9f,stroke:#333,stroke-width:4px
-```
-
 ----------------------------------------------
 
 *Built with [StencilJS](https://stenciljs.com/)*
diff --git a/src/components/credential-detail/test/d-credential-detail.spec.tsx b/src/components/credential-detail/test/d-credential-detail.spec.tsx
@@ -12,7 +12,6 @@ describe('d-credential-detail', () => {
         <mock:shadow-root>
          <div class="frame">
             <div class="heading">
-              <d-avatar></d-avatar>
               <span class="name"></span>
             </div>
            <div class="info">